Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to multi-stage build for container-features #10

Closed
3 tasks done
stuartleeks opened this issue May 11, 2022 · 0 comments · Fixed by #38
Closed
3 tasks done

Move to multi-stage build for container-features #10

stuartleeks opened this issue May 11, 2022 · 0 comments · Fixed by #38
Assignees

Comments

@stuartleeks
Copy link
Collaborator

stuartleeks commented May 11, 2022

This issue proposes moving the container-features build over to using a multi-stage docker build.

Prior to container-features, it was possible to build the dev container image with an inline cache manifest, push it to a registry and then reference that image in the cacheFrom in devcontainer.json (or in cache_from in docker-compose.yml) to have the registry image used as a layer cache.
When using container-features, there are now two images built, so you would need to push two images to the registry and reference two images in the cacheFrom.

Making this change will result in a single image build step for the container which will allow for pushing the resulting image to a registry complete with an inline cache manifest, making it possible to get back to the single dev container image that works for image caching.

Anticipated steps:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant