Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable expansion in secrets file #555

Open
yokonao opened this issue Jun 18, 2023 · 1 comment
Open

Variable expansion in secrets file #555

yokonao opened this issue Jun 18, 2023 · 1 comment

Comments

@yokonao
Copy link
Contributor

yokonao commented Jun 18, 2023

Hi,

I would like to express my sincere gratitude to the maintainers of this wonderful tool.

I have a question concerning the --secrets-file option. Currently, the file passed to --secrets-file is interpreted as a raw jsonc file. However, I would like to use some variable syntax, which is already used in devcontainer.json.

For example, I would like to use the following syntax in my secrets file:

{
  "GITHUB_TOKEN": "${localEnv:GITHUB_TOKEN}"
}

instead of:

{
  "GITHUB_TOKEN": "ghp********"
}

I would like to know the maintainer team's opinion on whether this idea is reasonable or not.

Thank you in advance.

@bamurtaugh
Copy link
Member

Thanks so much for your issue and feedback @yokonao!

@eljog do you have any thoughts here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants