Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global gitconfig fails to copy to devcontainer with postCreateCommand #787

Open
AvinZarlez opened this issue Mar 25, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@AvinZarlez
Copy link

Related to this issue #98 there still seems to be a problem for the global git config.

My local git config is copied, but my global git config is not. Settings that only existed in my global config like my name and email are not copied.

It seems that a default empty global git config is created when using postCreateCommand. In my case, I am running a script "postCreateCommand": "sh ./scripts/env-setup.sh"

Here is what my containers global git config looks like when using postCreateCommand:

# This is Git's per-user configuration file.
[user]
# Please adapt and uncomment the following lines:
#	name = 
#	email = vscode@b97bec6ca4f1.(none)

If I change it to postAttachCommand, then an exact copy of my actual global git config file from my machine is copied correctly into the dev container.

@chrmarti
Copy link
Contributor

We could ignore the empty [user] section. As a workaround you can comment out the [user] line as # [user].

@chrmarti chrmarti self-assigned this Mar 26, 2024
@chrmarti chrmarti added the bug Something isn't working label Mar 26, 2024
@AvinZarlez
Copy link
Author

I confirmed manually removing the global file ( or commenting out the empty user section ) does make it so the proper global file will be copied. Although that is a manual step that may be annoying/easy to miss/hard to explain to developers when making a fresh container.

I think ignoring an empty [user] section is ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants