Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Features with appropriate installsAfter properties #195

Closed
joshspicer opened this issue Oct 5, 2022 · 3 comments · Fixed by #214
Closed

update Features with appropriate installsAfter properties #195

joshspicer opened this issue Oct 5, 2022 · 3 comments · Fixed by #214

Comments

@joshspicer
Copy link
Member

Update features to include an installsAfter property where applicable. Notably, to install after common-utils

@joshspicer
Copy link
Member Author

should wait for devcontainers/cli#163 to be resolved.

@johnnyreilly
Copy link

johnnyreilly commented Oct 5, 2022

Is this related to devcontainers/spec#109?

@joshspicer
Copy link
Member Author

joshspicer commented Oct 11, 2022

Yea in a way @johnnyreilly - This issue really represents adding installsAfter: common-utils to mot of the Features in this repo, since common-utils is really designed to be installed earlier on in the build. (I quite liked this comment describing why we are trying to avoid Features having a strict dependency - devcontainers/spec#109 (comment))

The concept of "Composite Features" that @Chuxel was describing is unimplemented, and is a much firmer dependency. installsAfter is a hint but we don't require that the target Features of installsAfter be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants