Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Cargo cache persistence in Docker Volume #117

Closed
eitsupi opened this issue Jan 30, 2023 · 2 comments · Fixed by #125
Closed

[Rust] Cargo cache persistence in Docker Volume #117

eitsupi opened this issue Jan 30, 2023 · 2 comments · Fixed by #125
Labels
enhancement New feature or request

Comments

@eitsupi
Copy link
Contributor

eitsupi commented Jan 30, 2023

Do you think it is worth including in the template with the following settings, which share the Cargo cache between builds and containers, commented out?

{
	"source": "devcontainer-cargo-cache",
	"target": "/usr/local/cargo",
	"type": "volume"
}
@samruddhikhandale
Copy link
Member

I think we could. How about adding something like 👇 ?

    "mounts": [
        {
            "source": "devcontainer-cargo-cache-${devcontainerId}",
            "target": "/usr/local/cargo",
            "type": "volume"
        }
    ]

@samruddhikhandale samruddhikhandale added the enhancement New feature or request label Jan 31, 2023
@eitsupi
Copy link
Contributor Author

eitsupi commented Jan 31, 2023

I think we could. How about adding something like 👇 ?

    "mounts": [
        {
            "source": "devcontainer-cargo-cache-${devcontainerId}",
            "target": "/usr/local/cargo",
            "type": "volume"
        }
    ]

Thanks for your response.
I think this is a safe volume to share among all containers, but your suggestion is more safer so I think it is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants