Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET C# Image/Template to support & use .NET7 #38

Closed
warrenbuckley opened this issue Nov 10, 2022 · 10 comments
Closed

Update .NET C# Image/Template to support & use .NET7 #38

warrenbuckley opened this issue Nov 10, 2022 · 10 comments
Assignees

Comments

@warrenbuckley
Copy link

With the release of .NET7 released this week.
It makes sense if the .NET C# DevContainer template supports .NET7

https://github.com/devcontainers/templates/tree/main/src/dotnet

Currently it only supports the following

  • 6.0
  • 3.1
  • 6.0-bullseye
  • 3.1-bullseye
  • 6.0-focal
  • 3.1-focal

I am not sure who to ping or ask for help with this, I see the latest committer to these files is @samruddhikhandale so perhaps you can help with this?

@samruddhikhandale samruddhikhandale self-assigned this Nov 10, 2022
@warrenbuckley
Copy link
Author

I can't publicly browse the mcr.microsoft.com/devcontainers/dotnet URL,
I can only assume that there is not a prebuilt devcontainer image yet for 7.0

@samruddhikhandale
Copy link
Member

Yes, in order to update this template we needmcr.microsoft.com/devcontainers/dotnet:7.0

Once changes in devcontainers/images#201 are merged & deployed, then I'll work on updating the template.

@warrenbuckley
Copy link
Author

Additionally, I found the feature to add the .NET CLI
https://containers.dev/features
https://github.com/devcontainers/features/tree/main/src/dotnet

Could this be an alternative approach perhaps?

@samruddhikhandale
Copy link
Member

Could this be an alternative approach perhaps?

It's a nice suggestion. However, for templates, we are currently following a pattern to use the images for simplicity. If necessary, we then build using Features from https://github.com/devcontainers/features. As we plan to deploy the Images by Monday, I'll quickly update the dotnet Template when images are live. It will avoid changes to the current Template.

In the meanwhile, feel free to use dotnet 7 with Feature as follows -

"features": {
    "ghcr.io/devcontainers/features/dotnet:1": {
        "version": "7"
    }
}

@samruddhikhandale
Copy link
Member

@warrenbuckley ℹ️ You can look for all the published tags for dotnet image here

@warrenbuckley
Copy link
Author

The feature approach works perfectly fine for me, so thanks @samruddhikhandale to install .NET7 SDK tools

I am not sure why you would not want to use a smaller/slimmer image and then use the features to get the correct SDK version you want to use. For easier maintenance ?

@samruddhikhandale
Copy link
Member

Updated the Template with .NET 7 options as the corresponding images are live 🚀

image

// cc - @warrenbuckley

@warrenbuckley
Copy link
Author

Hi @samruddhikhandale
Will the template for C# (.NET) and MS SQL be updated as well?

image

image

@samruddhikhandale
Copy link
Member

Hi @warrenbuckley 👋

Yes, I have another PR in review to update those - #43

@samruddhikhandale
Copy link
Member

Updated 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants