Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add|kkkkkabir #10

Closed
kkkkkabir opened this issue Aug 20, 2020 · 10 comments
Closed

add|kkkkkabir #10

kkkkkabir opened this issue Aug 20, 2020 · 10 comments

Comments

@kkkkkabir
Copy link

kkkkkabir commented Aug 20, 2020

Name: Updated README.md with my name | Link: EddieHubCommunity/open-source-practice#93
Name: Add Kabir Jain to Contributors list | Link: firstcontributions/first-contributions#29649
Name: Added a machine learning website to Blogs section | Link: fbdevelopercircles/FbDevcCommunityContent#223
Name: Added hackathons section | Link: fbdevelopercircles/FbDevcCommunityContent#113
Name: Removed link "Google Reskilling India Program | Pluralsight" | Link: dipakkr/A-to-Z-Resources-for-Students#1281
Name: Update CONTRIBUTORS.md | Link: dipakkr/A-to-Z-Resources-for-Students#1280
Name: Update README.md | Link: matiassingers/awesome-readme#135

@github-actions
Copy link

Something happened: Link is not valid please create another issue with valid link.

@shriaas2898
Copy link
Collaborator

Hey @kkkkkabir you have to remove <> while adding the link.

@kkkkkabir
Copy link
Author

Hi! I even removed <> in my previous issue but still, it didn't work.

@AJV009
Copy link
Member

AJV009 commented Aug 20, 2020

hey @kkkkkabir here is an md example of what it should look like!

**Name:** PR Name | **Link**: https://github.com/link-to-pr

@kkkkkabir
Copy link
Author

@AJV009 I did just like that too...but still it didn't work. It doesn't show https://

@AJV009
Copy link
Member

AJV009 commented Aug 20, 2020

mmm looks weird
let me test too, ill soon let you know

@AJV009
Copy link
Member

AJV009 commented Aug 20, 2020

@kkkkkabir ITS WORKING!
see my last 2-3 issues
both update and addition are working

@kkkkkabir
Copy link
Author

@AJV009 I'll try again then.

@AJV009
Copy link
Member

AJV009 commented Aug 20, 2020

@AJV009 I'll try again then.

Hey @kkkkkabir, there was a bug!
"|" characters are skipped by the program and considered as next section!
SO it is a kind of clear bug!
your #7 was correct!
for the time being remove the "|" from this line "Google Reskilling India Program | Pluralsight"

**Name:** Removed link "Google Reskilling India Program | Pluralsight" | **Link**: https://github.com/dipakkr/A-to-Z-Resources-for-Students/pull/1281

so it would look like

**Name:** Removed link "Google Reskilling India Program Pluralsight" | **Link**: https://github.com/dipakkr/A-to-Z-Resources-for-Students/pull/1281

Let us know if you still face an issue!

@kkkkkabir
Copy link
Author

Oh, I thought that too but didn't implement it. I'll see if that works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants