Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded hostname & port number in nginx.conf #13

Open
Da-Geek opened this issue Aug 3, 2023 · 1 comment
Open

Hard coded hostname & port number in nginx.conf #13

Da-Geek opened this issue Aug 3, 2023 · 1 comment

Comments

@Da-Geek
Copy link

Da-Geek commented Aug 3, 2023

I know this is almost a non-issue, But...

proxy_pass http://develancacheui_backend:80;

Line 23 in the nginx.conf has the hostname & port number hard coded.
This could use the variable that is already required and being passed in as BACKENDURL as the value for line 23.
Maybe using the existing DeveLanCacheUI_Frontend/nginxconfig/30-setupenvironmentvariables.sh file to rewrite/update
Line23 of the nginx.conf at start-up?

This would allow the the backend and frontend to be on separate machines/hosts and allow people to change the compose
service names, or deploy without using a compose at all.

(as a side note, shouldn't Line 23 also be using the "Exposed" port number instead of :80 )

@devedse
Copy link
Owner

devedse commented Jan 18, 2024

Hello,

This logic makes sure that when you query the frontend URL it's automatically passing the queries on to the backend (by it's container name). What you could do is simply specify a backend url and then ensure CORS works by placing NGINX Proxy Manager in between.

I'm not sure if that's what you want or if you're really looking to fix it this way?

-Devedse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants