Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X support #32

Closed
raxcat opened this issue Oct 4, 2015 · 1 comment
Closed

OS X support #32

raxcat opened this issue Oct 4, 2015 · 1 comment

Comments

@raxcat
Copy link
Contributor

raxcat commented Oct 4, 2015

Hey, finally found a new framework except Objective-Flickr.

I read issues and there were 2 issues #2 and #11 regarding to this.

But the pull request was not finished yet. Is there any problem out there.

I would like to help creating an OS X framework(with module support) and OS X demo app.

@raxcat
Copy link
Contributor Author

raxcat commented Oct 4, 2015

Hey I fork the repo. And commit the first version of supporting OSX. raxcat@6e0026e

To prevent too much shimming(#If TARGET_OS_IPHONE) which would cause troubles maintaining code, I created DUImage in FKDataTypes.h just as previously discussed.

#if TARGET_OS_IPHONE
typedef UIImage DUImage;
#else
typedef NSImage DUImage;
#endif

Though, there are still some stuffs from AssetsLibrary would cause cross-platform issues. Cause there are few codes related to this, I just use shimming for AssetsLibrary related codes.

I also modified FlickrKit.h to support module(OSX). I did not modify anything regarding to iOS static library.

The OS X demo app does not demo well now. I am working on it.

BTW

FOUNDATION_EXPORT double FlickrKitOSXVersionNumber;
FOUNDATION_EXPORT const unsigned char FlickrKitOSXVersionString[];

will be changed to

FOUNDATION_EXPORT double FlickrKitVersionNumber;
FOUNDATION_EXPORT const unsigned char FlickrKitVersionString[];

in case the iOS library needs to support module, inspired by Alamofire swift frameworks (Actually the name doesn't matter but I will change them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants