Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The readme should reflect that the element that receives virtual.style needs box-sizing: border-box #58

Closed
mindnektar opened this issue Jul 13, 2017 · 1 comment

Comments

@mindnektar
Copy link

I've spent some time trying to figure out why my react-virtual-list implementation kept scrolling down after I reached the bottom, seemingly increasing the list's size the further I scrolled. After I dug into how this library works, at some point it became really obvious what the problem was: With each list item vanishing above the viewport, more padding was added to the list, which in turn was added to the list's height because I hadn't set box-sizing: border-box on it previously.

If this requirement was included somewhere in the readme, that might prevent some pain getting started. Otherwise, really good job with this!

@mindnektar
Copy link
Author

This is a duplicate of #56

@mindnektar mindnektar marked this as a duplicate of #56 Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant