Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "sass" option to the UI question when generating a new app. #17

Closed
NullVoxPopuli opened this issue Apr 19, 2019 · 0 comments · Fixed by #18
Closed

Add a "sass" option to the UI question when generating a new app. #17

NullVoxPopuli opened this issue Apr 19, 2019 · 0 comments · Fixed by #18

Comments

@NullVoxPopuli
Copy link
Contributor

Currently, sass is included by default.

Some projects may opt to use some variant of CSS-in-JS / inline-styles over sass, so when sass is not selected during project creation, we need to:

  • not generate components with sass files
  • not include a global sass file.

This means that the generated app needs to know about what options it was generated with.
I propose a .react-cli.js file that keeps track of the options that were used to create it.

an example of this file may be something like:

'use strict';

module.exports = {
  appBlueprintVersion: '0.1.1',

  features: {
    redux: true,
  },
  styles: {
    sass: false,
    materialUi: true,
  }
}

then when generating a component, we can look at this file, see if the app has sass or material or whatever, and adjust the output accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant