Skip to content

Commit

Permalink
Revert the lookup on documentView since introduces regression (#1631)
Browse files Browse the repository at this point in the history
  • Loading branch information
cristianbote authored and JoviDeCroock committed May 15, 2019
1 parent 38c4f64 commit 50f7f75
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/diff/props.js
Expand Up @@ -62,7 +62,7 @@ function setProperty(dom, name, value, oldValue, isSvg) {
else if (name[0]==='o' && name[1]==='n') {
let useCapture = name !== (name=name.replace(/Capture$/, ''));
let nameLower = name.toLowerCase();
name = (nameLower in dom.ownerDocument.defaultView ? nameLower : name).slice(2);
name = (nameLower in dom ? nameLower : name).slice(2);

if (value) {
if (!oldValue) dom.addEventListener(name, eventProxy, useCapture);
Expand Down
2 changes: 1 addition & 1 deletion test/browser/render.test.js
Expand Up @@ -540,7 +540,7 @@ describe('render()', () => {
it('should register events not appearing on dom nodes', () => {
let onAnimationEnd = () => {};

render(<div onAnimationEnd={onAnimationEnd} />, scratch);
render(<div onanimationend={onAnimationEnd} />, scratch);
expect(proto.addEventListener).to.have.been.calledOnce.and.to.have.been.calledWithExactly('animationend', sinon.match.func, false);
});

Expand Down

0 comments on commit 50f7f75

Please sign in to comment.