Better Integration for TypeScript + Preact + Unistore

[yokotaso]

I write PoC program with TypeScript, Preact, Unistore(Preact & Unistore is great!)

I happened TypeScript error. Because type definition of onClick is like below(in jsx.d.ts):

onClick?: MouseEventHandler;
type MouseEventHandler = EventHandler<MouseEvent>;
interface EventHandler<E extends Event> {
		(event: E): void;
}

So onClick accepts function that has 1 argument, and the type is MouseEvent.
But Integrate with unistore, first argument of function is State object.

TypeScript compile error:

Sample code is here: https://github.com/yokotaso/preact-unistore-typescript-integration

I suggest to add UnistoreEventHandler for unistore.

[coveralls]

Coverage remained the same at 100.0% when pulling 6f67a04 on yokotaso:jsx-unistore into 5cac157 on developit:master.

[marvinhagemeister]

Thanks for your PR 🎉 I'm honestly uneasy with adding library specific code to preact. If we start with it soon others will follow and we'll be forced to maintain it. Maybe there is a way to fix this in the typings for unistore? That would be a lot cleaner 🙂

[ForsakenHarmony]

As Marvin said, this is the wrong place, we can't add library specific typings

One solution to the problem would be to use props.increment.bind(null, null)

But your typings for the props are incorrect as well, the function doesn't take the state as an argument, that gets added by unistore

the correct type would be increment(): void;, as it doesn't return the update either

[yokotaso]

@marvinhagemeister @ForsakenHarmony
Thank you. I readlized that I misunderstood type of unistore