Store text node's text content as VNode.props instead of VNode.text #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
approved these changes
May 4, 2019
robertknight
added a commit
to preactjs/enzyme-adapter-preact-pure
that referenced
this pull request
Jun 1, 2019
The representation of text nodes changed in this release due to preactjs/preact#1600. The `text` property is no longer present on vnodes. Instead strings or numbers passed to `createElement` get converted to vnodes with type `null` and `vnode.props` equal to the string or number value. This PR is backwards-compatible with earlier betas. Fixes #48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies how text VNodes are represented internally. Instead of storing a text node's text content as
vnode.textthe content string is stored asvnode.props. This should be ok, as previously text nodes have hadnullas.props, and non-text nodes havenullas.text.Text node handling is still circuited when diffing, and the performance seems to stay on the same level with master. I used Chrome 74, MacOS 10.14.4 and https://github.com/mathieuancelin/js-repaint-perfs for testing, so YMMV.
These changes bring the preact.js.gz bundle size down by 28 bytes.
Some tests had to be modified accordingly. One now-irrelevant test got removed altogether. The devtools integration code also required some modifications - all devtools tests are passing, but I haven't actually tried to run the code with React devtools.