Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support node v6 in 1.3 branch #47

Closed
springmeyer opened this issue Mar 7, 2012 · 2 comments
Closed

support node v6 in 1.3 branch #47

springmeyer opened this issue Mar 7, 2012 · 2 comments

Comments

@springmeyer
Copy link
Collaborator

This is needed for TileMill, since TileMill does not yet use bones 2.x.

This commit (3e3a0b6) was all that was needed since the latest express 2.x supports both node v4 and node v6.

Tests pass before and after this change with node v0.4.12 and after with node v.0.6.11.

Although we have a new warning with node v0.6.11:


(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.
Trace: 
    at [object Object].<anonymous> (events.js:139:15)
    at [object Object].once (events.js:160:8)
    at [object Object].listen (net.js:775:10)
    at Function.response (/usr/local/lib/node_modules/expresso/bin/expresso:424:16)
    at Test.fn (/Users/dane/projects/tilemill/node_modules/bones/test/collections.test.js:15:12)
    at Test.runParallel (/usr/local/lib/node_modules/expresso/bin/expresso:959:10)
    at Test.run (/usr/local/lib/node_modules/expresso/bin/expresso:924:18)
    at next (/usr/local/lib/node_modules/expresso/bin/expresso:867:22)
    at runSuite (/usr/local/lib/node_modules/expresso/bin/expresso:875:6)
    at check (/usr/local/lib/node_modules/expresso/bin/expresso:814:12)
This was referenced Mar 7, 2012
@yhahn
Copy link
Collaborator

yhahn commented Mar 7, 2012

This looks good to go. I will confirm with @willwhite tomorrow -- then all that's needed is for this to be rolled into a tag?

@springmeyer
Copy link
Collaborator Author

this is now tagged in v1.3.24. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants