Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Includes in Program #5

Closed
Jules1337dev opened this issue Feb 15, 2023 · 4 comments
Closed

Search Includes in Program #5

Jules1337dev opened this issue Feb 15, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Jules1337dev
Copy link

Hi Ludwig,

its me again :) is it currently planned from your side to explore includes when searching a string within a program.
This would be very helpful for e.g. SAPMV45A.

Thanks and BR
Julian

@Jules1337dev Jules1337dev changed the title Search Includes in Programm Search Includes in Program Feb 15, 2023
@stockbal
Copy link
Member

Hi Julian,

Initially I have considered it. Maybe I will have a another look how much effort it would be to include it.

BR,
Ludwig

@stockbal stockbal added the enhancement New feature or request label Feb 15, 2023
@stockbal stockbal self-assigned this Feb 19, 2023
@stockbal
Copy link
Member

stockbal commented Feb 20, 2023

Hi Julian,

The Feature has been implemented and can be activated via a new setting in the Search Dialog:
image

The results in includes of programs will be grouped under the Program node:
image

This requires an update of both the ADT backend and frontend

@Jules1337dev
Copy link
Author

Hi Ludwig,

I have updated the backend and frotend and....
...it works!!

I wanted to add that i think the runtime is great.
A search for "loop" in sapmv45a with 3,200 hits only takes about 2 seconds.

Great job. It will enrich my life so much and make work easier.
Many many thanks to you!

BR
Julian

@stockbal
Copy link
Member

Hi Julian,

you are very welcome. 😉

BR,
Ludwig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants