Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Operator should update deployment when headless boolean is updated #1258

Open
3 tasks
kim-tsao opened this issue Sep 19, 2023 · 1 comment
Open
3 tasks
Labels
area/registry Devfile registry for stacks and infrastructure kind/user-story User story for new enhancement

Comments

@kim-tsao
Copy link
Contributor

kim-tsao commented Sep 19, 2023

/kind user-story

Which area this user story is related to?

/area registry

User Story

As a devfile registry admin I want to update my existing deployment so it can run either headless or non-headless

Currently, when a DevfileRegistry is deployed and a patch update is made changing the headless boolean from true to false, I expect an additional pod for the registry-viewer to be created but the update does not get triggered because we do not handle that configuration: https://github.com/devfile/registry-operator/blob/main/controllers/update.go

cat <<EOF | oc apply -n test -f -
apiVersion: registry.devfile.io/v1alpha1
kind: DevfileRegistry
metadata:
  name: devfile-registry-test
spec:
  tls:
    enabled: false
  devfileIndexImage: quay.io/devfile/devfile-index:next
  headless: true
EOF

Acceptance Criteria

  • Updates should be supported when headless is toggled between true and false
  • Unit/Controller tests are added
  • Documentation for DevfileRegistry CRD updated

Updated 2023-12-21 by: @michael-valdron

@openshift-ci openshift-ci bot added the kind/user-story User story for new enhancement label Sep 19, 2023
@kim-tsao kim-tsao added the area/registry Devfile registry for stacks and infrastructure label Sep 19, 2023
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Dec 19, 2023
@michael-valdron michael-valdron removed the lifecycle/stale Stale items. These items have not been updated for 90 days. label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure kind/user-story User story for new enhancement
Projects
Status: Refinement
Development

No branches or pull requests

2 participants