Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mocks for better testing #383

Closed
dharmit opened this issue Mar 19, 2021 · 0 comments · Fixed by devfile/library#93
Closed

Create mocks for better testing #383

dharmit opened this issue Mar 19, 2021 · 0 comments · Fixed by devfile/library#93
Assignees
Labels
area/library Common devfile library for interacting with devfiles
Projects

Comments

@dharmit
Copy link

dharmit commented Mar 19, 2021

With devfile/library#62 going in, a bunch of unit tests broke in odo repository. These tests are being modified on odo repo for the time being instead of merging devfile/library#72 (since that seemed like a step backward), but it would be helpful to have mocks in place for better unit testing in tools dependent on the library.

This would be helpful because, at the moment, we need to call functions to create a valid DevfileData with different kinds of components and commands. Mocking these would provide more flexibility and cleaner unit tests.

cc @mik-dass @kadel @maysunfaisal

@maysunfaisal maysunfaisal added the area/library Common devfile library for interacting with devfiles label Mar 19, 2021
@maysunfaisal maysunfaisal self-assigned this May 31, 2021
@maysunfaisal maysunfaisal added this to Under consideration in Sprint 202 via automation May 31, 2021
@maysunfaisal maysunfaisal moved this from Under consideration to In progress in Sprint 202 May 31, 2021
@maysunfaisal maysunfaisal moved this from In progress to Review in progress in Sprint 202 Jun 7, 2021
Sprint 202 automation moved this from Review in progress to Done Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants