Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce component "objects" ( aka list of Kube objects ) #54

Open
sbose78 opened this issue May 20, 2020 · 3 comments
Open

Introduce component "objects" ( aka list of Kube objects ) #54

sbose78 opened this issue May 20, 2020 · 3 comments
Labels
future Items in consideration to be added to future spec levels lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@sbose78
Copy link

sbose78 commented May 20, 2020

As a stack/devfile author, I wish to convey outer-loop deployment guidance in the form of a list of parameterized kubernetes objects.

The format draws inspiration from Templates https://github.com/sbose78/nodejs-rest-http-crud/blob/master/.openshiftio/application.yaml#L38

---

 components:   
   -  id: deploy-node-app
      parameters:
         - name: ${image}
           value: quay.io/quarkus-quickstarts/getting-started-knative ## Default
       objects:
         - apiVersion: serving.knative.dev/v1alpha1
            kind: Service
            metadata:
              name: greeter
            spec:
              template:
                spec:
                  containers:
                    - image: ${image}
                      livenessProbe:
                      httpGet:
                        path: /health/live
                      readinessProbe:
                      httpGet:
                        path: /health/ready

If the objects component is associated with a dockerfile component (image build guidance) in a composite command, #51 , che/odo must associate the built image from the 'build' guidance using the image parameter.

- composite:
      id: build-and-deploy
      label: Build image and deploy nodejs app
      commands:
      - build-node-app
      - deploy-node-app
      parallel: false
      group: 
          kind: deploy
@EnriqueL8
Copy link
Contributor

Would it be simpler for a user to have the ability to specify a path or a link to a deployment manifest containing these objects? The tool consuming this would then apply the templating on that file.

@l0rd
Copy link
Contributor

l0rd commented Jun 8, 2020

@EnriqueL8 that is already supported using a component of type kubernetes.

@l0rd l0rd added this to the 2.1.0 milestone Jun 11, 2020
@elsony elsony removed this from the 2.2 milestone Mar 24, 2022
@elsony elsony added the future Items in consideration to be added to future spec levels label Mar 24, 2022
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future Items in consideration to be added to future spec levels lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
Status: Refinement
Development

No branches or pull requests

4 participants