Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename command group type #59

Closed
maysunfaisal opened this issue Jun 1, 2020 · 2 comments · Fixed by #94
Closed

Rename command group type #59

maysunfaisal opened this issue Jun 1, 2020 · 2 comments · Fixed by #94
Labels
area/api Enhancement or issue related to the api/devfile specification kind/bug Something isn't working severity/P1 Issues that have a critical impact
Milestone

Comments

@maysunfaisal
Copy link
Member

As odo is working on consuming the v2 spec, i noticed that the command group kind is called command group type https://github.com/devfile/kubernetes-api/blob/master/pkg/apis/workspaces/v1alpha1/commands.go#L20

// CommandGroupType describes the kind of command group.
// +kubebuilder:validation:Enum=build;run;test;debug
type CommandGroupType string

Can we please rename this to CommandGroupKind to be consistent with the discussion here in #27 and also devfile actually uses kind instead of type:

commands:
  - exec:
      id: devBuild
      component: runtime
      commandLine: npm install
      workingDir: ${CHE_PROJECTS_ROOT}/nodejs-web-app/app
      group:
        kind: build
        isDefault: true
@l0rd
Copy link
Contributor

l0rd commented Jun 8, 2020

@maysunfaisal you are right. We need to address that. If you have the chance don't hesitate to open a PR.

@l0rd l0rd added the kind/bug Something isn't working label Jun 8, 2020
@l0rd l0rd added area/api Enhancement or issue related to the api/devfile specification severity/P1 Issues that have a critical impact labels Jun 24, 2020
@l0rd l0rd added this to the 2.0 milestone Jun 24, 2020
@davidfestal davidfestal linked a pull request Jul 6, 2020 that will close this issue
@davidfestal
Copy link
Collaborator

Fxed in PR #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Enhancement or issue related to the api/devfile specification kind/bug Something isn't working severity/P1 Issues that have a critical impact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants