Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation fails on devfile 2.0.0 with unknown ephemeral field on volume #697

Closed
feloy opened this issue Nov 26, 2021 · 2 comments
Closed
Assignees
Labels
area/api Enhancement or issue related to the api/devfile specification area/library Common devfile library for interacting with devfiles kind/bug Something isn't working

Comments

@feloy
Copy link
Contributor

feloy commented Nov 26, 2021

/kind bug

Which area this bug is related to?

/area library

What versions of software are you using?

Operating System:

Fedora Linux

Go Pkg Version:

Bug Summary

Describe the bug:

When saving a devfile, the devfile library is adding an ephemeral field to the volume structure on devfile v2.0, but this field is supported starting at v2.1 only.

To Reproduce:

$ odo create nodejs
$ odo storage create vol1
$ odo describe
# works
$ odo storage create vol2
$ odo describe
 ✗  invalid devfile schema. errors :
- components.1.volume: Additional property ephemeral is not allowed

Suggestion on how to fix the bug

The problem seems very similar to #675

@openshift-ci openshift-ci bot added kind/bug Something isn't working area/library Common devfile library for interacting with devfiles labels Nov 26, 2021
@feloy
Copy link
Contributor Author

feloy commented Nov 26, 2021

CC @anandrkskd for PR redhat-developer/odo#5252

@yangcao77 yangcao77 self-assigned this Nov 30, 2021
@yangcao77 yangcao77 added this to Under consideration in Sprint 210 via automation Nov 30, 2021
@yangcao77 yangcao77 assigned kim-tsao and unassigned yangcao77 Nov 30, 2021
@yangcao77
Copy link
Contributor

This is the boolean value omitempty issue which was resolved by @kim-tsao in 2.2.0. Just need to port over the change from 2.2.0 to 2.1.0 as well. This won't affect any devfile usage, but will affect the api spec. assigning to Kim to take a look.

@yangcao77 yangcao77 added the area/api Enhancement or issue related to the api/devfile specification label Nov 30, 2021
@kim-tsao kim-tsao moved this from Under consideration to In progress in Sprint 210 Nov 30, 2021
@johnmcollier johnmcollier removed this from In progress in Sprint 210 Dec 2, 2021
@johnmcollier johnmcollier added this to Under consideration in Sprint 211/212 via automation Dec 2, 2021
@johnmcollier johnmcollier moved this from Under consideration to In progress in Sprint 211/212 Dec 2, 2021
@kim-tsao kim-tsao moved this from In progress to Review in progress in Sprint 211/212 Dec 6, 2021
@kim-tsao kim-tsao closed this as completed Dec 8, 2021
Sprint 211/212 automation moved this from Review in progress to Done Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Enhancement or issue related to the api/devfile specification area/library Common devfile library for interacting with devfiles kind/bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

3 participants