Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands from Python devfile should be improved #777

Closed
Tracked by #21063
svor opened this issue Feb 17, 2022 · 2 comments · Fixed by devfile/registry#96
Closed
Tracked by #21063

Commands from Python devfile should be improved #777

svor opened this issue Feb 17, 2022 · 2 comments · Fixed by devfile/registry#96
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working

Comments

@svor
Copy link

svor commented Feb 17, 2022

/kind bug

Which area this bug is related to?

/area registry

What versions of software are you using?

Eclipse Che 7.42

Bug Summary

Describe the bug:
Commands from Python base devfile are failed.

  • The reason is that workingDir is not pointed to the project sample dir.
  • debugpy command uses env DEBUG_PORT which is not defined

To Reproduce:

  • Create a workspace form Python devfile
  • Try to execute any command

Expected behavior

Commands should be executed

Suggestion on how to fix the bug

  • add workingDir: ${PROJECT_SOURCE} to each command
  • set DEBUG_PORT env
@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Feb 17, 2022
@svor svor added the area/registry Devfile registry for stacks and infrastructure label Feb 17, 2022
@kadel
Copy link
Member

kadel commented Feb 21, 2022

  • add workingDir: ${PROJECT_SOURCE} to each command

already fixed in devfile/registry#85

  • set DEBUG_PORT env

devfile/registry#93

@svor
Copy link
Author

svor commented Feb 21, 2022

already fixed in devfile/registry#85

pip-install-requirements command doesn't have workingDir https://github.com/devfile/registry/blob/main/stacks/python/devfile.yaml#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants