-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devfile Library should have the ability to get resources from a private repo #984
Comments
contextCurrently, when a devfile is parsed from a uri
that is in a repo from a supported git provider, the resources from the repo are downloaded. problemIf we want to download from private repos, we need to authenticate with a token. How should this git token be passed into the library?
|
01/23 - Devfile community call
|
removing from hold; will continue with implementation with the potential of swapping out with SPI in the future |
experimenting with mocking a happy path test for cloning a repo edit 03/08
consumers will pass the token through the type ParserArgs struct {
...
+ // Token is a GitHub, GitLab, or Bitbucket personal access token used with a private git repo uri
+ Token string
...
} the single token passed from client means that:
future: will need to consider the case where the main and parent devfiles are in different private repos edit 03/21 found edge case where edit 03/28 edit 03/29 |
ongoing review progress; updating token location and url parsing |
moving back to in progress; unit tests are completed, but functional testing needs to be added / at the minimum explored properly before the PR can be merged. if functional tests can't be added, manual testing needs to be documented as a final option |
Found a way to add functional tests and completed the mocking setup; moved parent resource downloading into a separate method that can then be mocked. Currently creating the test cases with the mocks |
04/14 - added functional test cases, which required:
|
/kind user-story
Which area this user story is related to?
/area library
User Story
We would like if the devfile/library had the ability to get resources from a private repository. This would be required for reading devfile.yaml or an outerloop kubernetes deploy.yaml defined in the devfile for example.
The library should have the ability to read the private resources for most of the leading repositories like github, gitlab, bitbucket, etc.
In AppStudio, this is done using SPI but it would require installing their CRs and Controllers. But we could also look at the OpenShift Developer Console(ODC) as to how they do it for their codebase but their implementation would be in TS.
Acceptance Criteria
Target Date: 2023-04-28
The text was updated successfully, but these errors were encountered: