-
Notifications
You must be signed in to change notification settings - Fork 48
/
devworkspace_controller.go
475 lines (427 loc) · 18.9 KB
/
devworkspace_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
//
// Copyright (c) 2019-2021 Red Hat, Inc.
// This program and the accompanying materials are made
// available under the terms of the Eclipse Public License 2.0
// which is available at https://www.eclipse.org/legal/epl-2.0/
//
// SPDX-License-Identifier: EPL-2.0
//
// Contributors:
// Red Hat, Inc. - initial API and implementation
//
package controllers
import (
"context"
"fmt"
"net/http"
"strings"
"time"
controllerv1alpha1 "github.com/devfile/devworkspace-operator/apis/controller/v1alpha1"
"github.com/devfile/devworkspace-operator/controllers/workspace/provision"
"github.com/devfile/devworkspace-operator/pkg/common"
"github.com/devfile/devworkspace-operator/pkg/config"
"github.com/devfile/devworkspace-operator/pkg/constants"
"github.com/devfile/devworkspace-operator/pkg/library/annotate"
containerlib "github.com/devfile/devworkspace-operator/pkg/library/container"
"github.com/devfile/devworkspace-operator/pkg/library/flatten"
registry "github.com/devfile/devworkspace-operator/pkg/library/flatten/internal_registry"
"github.com/devfile/devworkspace-operator/pkg/library/projects"
"github.com/devfile/devworkspace-operator/pkg/provision/metadata"
"github.com/devfile/devworkspace-operator/pkg/provision/storage"
"github.com/devfile/devworkspace-operator/pkg/timing"
"github.com/go-logr/logr"
"github.com/google/uuid"
coputil "github.com/redhat-cop/operator-utils/pkg/util"
appsv1 "k8s.io/api/apps/v1"
batchv1 "k8s.io/api/batch/v1"
corev1 "k8s.io/api/core/v1"
k8sErrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"
dw "github.com/devfile/api/v2/pkg/apis/workspaces/v1alpha2"
)
// DevWorkspaceReconciler reconciles a DevWorkspace object
type DevWorkspaceReconciler struct {
client.Client
Log logr.Logger
Scheme *runtime.Scheme
}
/////// CRD-related RBAC roles
// +kubebuilder:rbac:groups=workspace.devfile.io,resources=*,verbs=*
// +kubebuilder:rbac:groups=controller.devfile.io,resources=*,verbs=*
/////// Required permissions for controller
// +kubebuilder:rbac:groups=apps;extensions,resources=deployments;replicasets,verbs=*
// +kubebuilder:rbac:groups="",resources=pods;serviceaccounts;secrets;configmaps;persistentvolumeclaims,verbs=*
// +kubebuilder:rbac:groups="",resources=namespaces,verbs=get;list;watch
// +kubebuilder:rbac:groups="batch",resources=jobs,verbs=get;create;list;watch;update;patch;delete
// +kubebuilder:rbac:groups=admissionregistration.k8s.io,resources=mutatingwebhookconfigurations;validatingwebhookconfigurations,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=roles;rolebindings;clusterroles;clusterrolebindings,verbs=get;list;watch;create;update
// +kubebuilder:rbac:groups=oauth.openshift.io,resources=oauthclients,verbs=get;list;watch;create;update;patch;delete;deletecollection
// +kubebuilder:rbac:groups=monitoring.coreos.com,resources=servicemonitors,verbs=get;create
// +kubebuilder:rbac:groups=apps,resourceNames=devworkspace-controller,resources=deployments/finalizers,verbs=update
/////// Required permissions for workspace ServiceAccount
// +kubebuilder:rbac:groups="",resources=pods/exec,verbs=create
// +kubebuilder:rbac:groups=apps;extensions,resources=replicasets,verbs=get;list;watch
// +kubebuilder:rbac:groups=apps;extensions,resources=deployments,verbs=get;list;watch
func (r *DevWorkspaceReconciler) Reconcile(req ctrl.Request) (reconcileResult ctrl.Result, err error) {
ctx := context.Background()
reqLogger := r.Log.WithValues("Request.Namespace", req.Namespace, "Request.Name", req.Name)
clusterAPI := provision.ClusterAPI{
Client: r.Client,
Scheme: r.Scheme,
Logger: reqLogger,
Ctx: ctx,
}
// Fetch the Workspace instance
workspace := &dw.DevWorkspace{}
err = r.Get(ctx, req.NamespacedName, workspace)
if err != nil {
if k8sErrors.IsNotFound(err) {
// Request object not found, could have been deleted after reconcile request.
// Owned objects are automatically garbage collected. For additional cleanup logic use finalizers.
// Return and don't requeue
return reconcile.Result{}, nil
}
// Error reading the object - requeue the request.
return reconcile.Result{}, err
}
reqLogger = reqLogger.WithValues(constants.DevWorkspaceIDLoggerKey, workspace.Status.DevWorkspaceId)
reqLogger.Info("Reconciling Workspace")
// Check if the DevWorkspaceRouting instance is marked to be deleted, which is
// indicated by the deletion timestamp being set.
if workspace.GetDeletionTimestamp() != nil {
reqLogger.Info("Finalizing DevWorkspace")
return r.finalize(ctx, reqLogger, workspace)
}
// Ensure workspaceID is set.
if workspace.Status.DevWorkspaceId == "" {
workspaceId, err := getWorkspaceId(workspace)
if err != nil {
return reconcile.Result{}, err
}
workspace.Status.DevWorkspaceId = workspaceId
workspace.Status.Phase = dw.DevWorkspaceStatusStarting
workspace.Status.Message = "Initializing DevWorkspace"
err = r.Status().Update(ctx, workspace)
return reconcile.Result{Requeue: true}, err
}
// Stop failed workspaces
if workspace.Status.Phase == devworkspacePhaseFailing && workspace.Spec.Started {
patch := []byte(`{"spec":{"started": false}}`)
err := r.Client.Patch(context.Background(), workspace, client.RawPatch(types.MergePatchType, patch))
if err != nil {
return reconcile.Result{}, err
}
// Requeue reconcile to stop workspace
return reconcile.Result{Requeue: true}, nil
}
// Handle stopped workspaces
if !workspace.Spec.Started {
timing.ClearAnnotations(workspace)
r.syncTimingToCluster(ctx, workspace, map[string]string{}, reqLogger)
return r.stopWorkspace(workspace, reqLogger)
}
// Prepare handling workspace status and condition
reconcileStatus := currentStatus{phase: dw.DevWorkspaceStatusStarting}
clusterWorkspace := workspace.DeepCopy()
timingInfo := map[string]string{}
timing.SetTime(timingInfo, timing.DevWorkspaceStarted)
defer func() (reconcile.Result, error) {
r.syncTimingToCluster(ctx, clusterWorkspace, timingInfo, reqLogger)
return r.updateWorkspaceStatus(clusterWorkspace, reqLogger, &reconcileStatus, reconcileResult, err)
}()
if workspace.Annotations[constants.DevWorkspaceRestrictedAccessAnnotation] == "true" {
msg, err := r.validateCreatorLabel(clusterWorkspace)
if err != nil {
return r.failWorkspace(workspace, msg, reqLogger, &reconcileStatus)
}
}
if _, ok := clusterWorkspace.Annotations[constants.DevWorkspaceStopReasonAnnotation]; ok {
delete(clusterWorkspace.Annotations, constants.DevWorkspaceStopReasonAnnotation)
err = r.Update(context.TODO(), clusterWorkspace)
return reconcile.Result{Requeue: true}, err
}
timing.SetTime(timingInfo, timing.ComponentsCreated)
// TODO#185 : Temporarily do devfile flattening in main reconcile loop; this should be moved to a subcontroller.
flattenHelpers := flatten.ResolverTools{
DefaultNamespace: workspace.Namespace,
Context: ctx,
K8sClient: r.Client,
InternalRegistry: ®istry.InternalRegistryImpl{},
HttpClient: http.DefaultClient,
}
flattenedWorkspace, err := flatten.ResolveDevWorkspace(&workspace.Spec.Template, flattenHelpers)
if err != nil {
return r.failWorkspace(workspace, fmt.Sprintf("Error processing devfile: %s", err), reqLogger, &reconcileStatus)
}
workspace.Spec.Template = *flattenedWorkspace
reconcileStatus.setConditionTrue(DevWorkspaceResolved, "Resolved plugins and parents from DevWorkspace")
storageProvisioner, err := storage.GetProvisioner(workspace)
if err != nil {
return r.failWorkspace(workspace, fmt.Sprintf("Error provisioning storage: %s", err), reqLogger, &reconcileStatus)
}
// Set finalizer on DevWorkspace if necessary
// Note: we need to check the flattened workspace to see if a finalizer is needed, as plugins could require storage
if isFinalizerNecessary(workspace, storageProvisioner) {
coputil.AddFinalizer(clusterWorkspace, storageCleanupFinalizer)
if err := r.Update(ctx, clusterWorkspace); err != nil {
return reconcile.Result{}, err
}
}
// Add init container to clone projects
projects.AddProjectClonerComponent(&workspace.Spec.Template)
devfilePodAdditions, err := containerlib.GetKubeContainersFromDevfile(&workspace.Spec.Template)
if err != nil {
return r.failWorkspace(workspace, fmt.Sprintf("Error processing devfile: %s", err), reqLogger, &reconcileStatus)
}
err = storageProvisioner.ProvisionStorage(devfilePodAdditions, workspace, clusterAPI)
if err != nil {
switch storageErr := err.(type) {
case *storage.NotReadyError:
reqLogger.Info(storageErr.Message)
reconcileStatus.setConditionFalse(StorageReady, fmt.Sprintf("Provisioning storage: %s", storageErr.Message))
return reconcile.Result{Requeue: true, RequeueAfter: storageErr.RequeueAfter}, nil
case *storage.ProvisioningError:
return r.failWorkspace(workspace, fmt.Sprintf("Error provisioning storage: %s", storageErr), reqLogger, &reconcileStatus)
default:
return reconcile.Result{}, storageErr
}
}
reconcileStatus.setConditionTrue(StorageReady, "Storage ready")
timing.SetTime(timingInfo, timing.ComponentsReady)
rbacStatus := provision.SyncRBAC(workspace, r.Client, reqLogger)
if rbacStatus.Err != nil || !rbacStatus.Continue {
return reconcile.Result{Requeue: true}, rbacStatus.Err
}
// Step two: Create routing, and wait for routing to be ready
timing.SetTime(timingInfo, timing.RoutingCreated)
routingStatus := provision.SyncRoutingToCluster(workspace, clusterAPI)
if !routingStatus.Continue {
if routingStatus.FailStartup {
return r.failWorkspace(workspace, routingStatus.Message, reqLogger, &reconcileStatus)
}
reqLogger.Info("Waiting on routing to be ready")
message := "Preparing networking"
if routingStatus.Message != "" {
message = routingStatus.Message
}
reconcileStatus.setConditionFalse(dw.DevWorkspaceRoutingReady, message)
return reconcile.Result{Requeue: routingStatus.Requeue}, routingStatus.Err
}
reconcileStatus.setConditionTrue(dw.DevWorkspaceRoutingReady, "Networking ready")
timing.SetTime(timingInfo, timing.RoutingReady)
statusOk, err := syncWorkspaceMainURL(clusterWorkspace, routingStatus.ExposedEndpoints, clusterAPI)
if err != nil {
return reconcile.Result{}, err
}
if !statusOk {
reqLogger.Info("Updating workspace status")
return reconcile.Result{Requeue: true}, nil
}
annotate.AddURLAttributesToEndpoints(&workspace.Spec.Template, routingStatus.ExposedEndpoints)
// Step three: provision a configmap on the cluster to mount the flattened devfile in deployment containers
err = metadata.ProvisionWorkspaceMetadata(devfilePodAdditions, clusterWorkspace, workspace, &clusterAPI)
if err != nil {
switch provisionErr := err.(type) {
case *metadata.NotReadyError:
reqLogger.Info(provisionErr.Message)
return reconcile.Result{Requeue: true, RequeueAfter: provisionErr.RequeueAfter}, nil
case *metadata.ProvisioningError:
return r.failWorkspace(workspace, fmt.Sprintf("Error provisioning metadata configmap: %s", provisionErr), reqLogger, &reconcileStatus)
default:
return reconcile.Result{}, provisionErr
}
}
// Step four: Collect all workspace deployment contributions
allPodAdditions := []controllerv1alpha1.PodAdditions{*devfilePodAdditions}
routingPodAdditions := routingStatus.PodAdditions
if routingPodAdditions != nil {
allPodAdditions = append(allPodAdditions, *routingPodAdditions)
}
// Step five: Prepare workspace ServiceAccount
saAnnotations := map[string]string{}
if routingPodAdditions != nil {
saAnnotations = routingPodAdditions.ServiceAccountAnnotations
}
serviceAcctStatus := provision.SyncServiceAccount(workspace, saAnnotations, clusterAPI)
if !serviceAcctStatus.Continue {
// FailStartup is not possible for generating the serviceaccount
reqLogger.Info("Waiting for workspace ServiceAccount")
reconcileStatus.setConditionFalse(dw.DevWorkspaceServiceAccountReady, "Waiting for DevWorkspace ServiceAccount")
return reconcile.Result{Requeue: serviceAcctStatus.Requeue}, serviceAcctStatus.Err
}
serviceAcctName := serviceAcctStatus.ServiceAccountName
reconcileStatus.setConditionTrue(dw.DevWorkspaceServiceAccountReady, "DevWorkspace serviceaccount ready")
pullSecretStatus := provision.PullSecrets(clusterAPI)
if !pullSecretStatus.Continue {
reconcileStatus.setConditionFalse(PullSecretsReady, "Waiting for DevWorkspace pull secrets")
return reconcile.Result{Requeue: pullSecretStatus.Requeue}, pullSecretStatus.Err
}
allPodAdditions = append(allPodAdditions, pullSecretStatus.PodAdditions)
reconcileStatus.setConditionTrue(PullSecretsReady, "DevWorkspace secrets ready")
// Step six: Create deployment and wait for it to be ready
timing.SetTime(timingInfo, timing.DeploymentCreated)
deploymentStatus := provision.SyncDeploymentToCluster(workspace, allPodAdditions, serviceAcctName, clusterAPI)
if !deploymentStatus.Continue {
if deploymentStatus.FailStartup {
return r.failWorkspace(workspace, deploymentStatus.Info(), reqLogger, &reconcileStatus)
}
reqLogger.Info("Waiting on deployment to be ready")
reconcileStatus.setConditionFalse(DeploymentReady, "Waiting for workspace deployment")
return reconcile.Result{Requeue: deploymentStatus.Requeue}, deploymentStatus.Err
}
reconcileStatus.setConditionTrue(DeploymentReady, "DevWorkspace deployment ready")
timing.SetTime(timingInfo, timing.DeploymentReady)
serverReady, err := checkServerStatus(clusterWorkspace)
if err != nil {
return reconcile.Result{}, err
}
if !serverReady {
reconcileStatus.setConditionFalse(dw.DevWorkspaceReady, "Waiting for editor to start")
return reconcile.Result{RequeueAfter: 1 * time.Second}, nil
}
timing.SetTime(timingInfo, timing.DevWorkspaceReady)
timing.SummarizeStartup(clusterWorkspace)
reconcileStatus.setConditionTrue(dw.DevWorkspaceReady, "")
reconcileStatus.phase = dw.DevWorkspaceStatusRunning
return reconcile.Result{}, nil
}
func (r *DevWorkspaceReconciler) stopWorkspace(workspace *dw.DevWorkspace, logger logr.Logger) (reconcile.Result, error) {
status := currentStatus{phase: dw.DevWorkspaceStatusStopping}
if workspace.Status.Phase == devworkspacePhaseFailing || workspace.Status.Phase == dw.DevWorkspaceStatusFailed {
status.phase = workspace.Status.Phase
failedCondition := getConditionByType(workspace.Status.Conditions, dw.DevWorkspaceFailedStart)
if failedCondition != nil {
status.setCondition(dw.DevWorkspaceFailedStart, *failedCondition)
}
}
stopped, err := r.doStop(workspace, logger)
if err != nil {
return reconcile.Result{}, err
}
if stopped {
switch status.phase {
case devworkspacePhaseFailing, dw.DevWorkspaceStatusFailed:
status.phase = dw.DevWorkspaceStatusFailed
default:
status.phase = dw.DevWorkspaceStatusStopped
}
}
return r.updateWorkspaceStatus(workspace, logger, &status, reconcile.Result{}, nil)
}
func (r *DevWorkspaceReconciler) doStop(workspace *dw.DevWorkspace, logger logr.Logger) (stopped bool, err error) {
workspaceDeployment := &appsv1.Deployment{}
namespaceName := types.NamespacedName{
Name: common.DeploymentName(workspace.Status.DevWorkspaceId),
Namespace: workspace.Namespace,
}
err = r.Get(context.TODO(), namespaceName, workspaceDeployment)
if err != nil {
if k8sErrors.IsNotFound(err) {
return true, nil
}
return false, err
}
replicas := workspaceDeployment.Spec.Replicas
if replicas == nil || *replicas > 0 {
logger.Info("Stopping workspace")
err = provision.ScaleDeploymentToZero(workspace, r.Client)
if err != nil && !k8sErrors.IsConflict(err) {
return false, err
}
return false, nil
}
if workspaceDeployment.Status.Replicas == 0 {
return true, nil
}
return false, nil
}
// failWorkspace marks a workspace as failed by setting relevant fields in the status struct.
// These changes are not synced to cluster immediately, and are intended to be synced to the cluster via a deferred function
// in the main reconcile loop. If needed, changes can be flushed to the cluster immediately via `updateWorkspaceStatus()`
func (r *DevWorkspaceReconciler) failWorkspace(workspace *dw.DevWorkspace, msg string, logger logr.Logger, status *currentStatus) (reconcile.Result, error) {
logger.Info("DevWorkspace failed to start: " + msg)
status.phase = devworkspacePhaseFailing
status.setConditionTrue(dw.DevWorkspaceFailedStart, msg)
if workspace.Spec.Started {
return reconcile.Result{Requeue: true}, nil
}
return reconcile.Result{}, nil
}
func (r *DevWorkspaceReconciler) syncTimingToCluster(
ctx context.Context, workspace *dw.DevWorkspace, timingInfo map[string]string, reqLogger logr.Logger) {
if timing.IsEnabled() {
if workspace.Annotations == nil {
workspace.Annotations = map[string]string{}
}
for timingEvent, timestamp := range timingInfo {
if _, set := workspace.Annotations[timingEvent]; !set {
workspace.Annotations[timingEvent] = timestamp
}
}
if err := r.Update(ctx, workspace); err != nil {
if k8sErrors.IsConflict(err) {
reqLogger.Info("Got conflict when trying to apply timing annotations to workspace")
} else {
reqLogger.Error(err, "Error trying to apply timing annotations to devworkspace")
}
}
}
}
func getWorkspaceId(instance *dw.DevWorkspace) (string, error) {
uid, err := uuid.Parse(string(instance.UID))
if err != nil {
return "", err
}
return "workspace" + strings.Join(strings.Split(uid.String(), "-")[0:3], ""), nil
}
// Mapping the pod to the devworkspace
func dwRelatedPodsHandler() handler.EventHandler {
podToDW := func(mapObj handler.MapObject) []reconcile.Request {
meta := mapObj.Meta
labels := meta.GetLabels()
if _, ok := labels[constants.DevWorkspaceNameLabel]; !ok {
return nil
}
//If the dewworkspace label does not exist, do no reconcile
if _, ok := labels[constants.DevWorkspaceIDLabel]; !ok {
return nil
}
return []reconcile.Request{
{
NamespacedName: types.NamespacedName{
Name: labels[constants.DevWorkspaceNameLabel],
Namespace: meta.GetNamespace(),
},
},
}
}
return &handler.EnqueueRequestsFromMapFunc{ToRequests: handler.ToRequestsFunc(podToDW)}
}
func (r *DevWorkspaceReconciler) SetupWithManager(mgr ctrl.Manager) error {
maxConcurrentReconciles, err := config.GetMaxConcurrentReconciles()
if err != nil {
return err
}
// TODO: Set up indexing https://book.kubebuilder.io/cronjob-tutorial/controller-implementation.html#setup
return ctrl.NewControllerManagedBy(mgr).
WithOptions(controller.Options{MaxConcurrentReconciles: maxConcurrentReconciles}).
For(&dw.DevWorkspace{}).
// List DevWorkspaceTemplates as owned to enable updating workspaces when templates
// are changed; this should be moved to whichever controller is responsible for flattening
// DevWorkspaces
Owns(&dw.DevWorkspaceTemplate{}).
Owns(&appsv1.Deployment{}).
Owns(&batchv1.Job{}).
Owns(&controllerv1alpha1.DevWorkspaceRouting{}).
Watches(&source.Kind{Type: &corev1.Pod{}}, dwRelatedPodsHandler()).
WithEventFilter(predicates).
WithEventFilter(podPredicates).
Complete(r)
}