Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging container contributions can break commands/events #1029

Closed
amisevsk opened this issue Jan 31, 2023 · 0 comments · Fixed by #1033
Closed

Merging container contributions can break commands/events #1029

amisevsk opened this issue Jan 31, 2023 · 0 comments · Fixed by #1033
Assignees
Milestone

Comments

@amisevsk
Copy link
Collaborator

Description

Given a devfile such as the che-code-latest.yaml sample, DWO will merge the che-code-runtime-description component into the tools container. However, this process can result in an invalid devfile, if the contribution component has commands that reference the now-merged component.

Instead, when merging a container contribution into another component, DWO should update and commands in the flattened devfile that reference that component to instead reference the merged component.

How To Reproduce

Apply a DevWorkspace that has a contribution with both

  • The controller.devfile.io/container-contribution: true attribute on a component, and
  • A command that references this component

Additional context

This issue breaks e.g. prestart and poststart commands for components with controller.devfile.io/container-contribution: true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant