Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git operations show warning when using credentials mounted by DWO #1121

Closed
amisevsk opened this issue Jun 9, 2023 · 0 comments · Fixed by #1145
Closed

Git operations show warning when using credentials mounted by DWO #1121

amisevsk opened this issue Jun 9, 2023 · 0 comments · Fixed by #1145
Assignees
Milestone

Comments

@amisevsk
Copy link
Collaborator

amisevsk commented Jun 9, 2023

Description

When git credentials are added to a workspace (doc), the credentials file is necessarily mounted read-only to the workspace containers.

This causes git operations, both in the running workspace and in the project-clone init container, to log

fatal: unable to get credential storage lock in 1000 ms: Read-only file system

This message does not prevent the action from succeeding (i.e. the clone/fetch/push succeeds) but the message is confusing and suggests an unexpected error.

How To Reproduce

  1. Configure git credentials via personal access token as documented
  2. Start a workspace that clones a git repository
  3. Note project clone logs contain message listed above
  4. Attempt to git fetch within the cloned project, note error printed as above.

Expected behavior

We should find a way of either ignoring or suppressing this error.

One approach would be to

  1. Mount credentials to some other path, and
  2. Copy file to the path git expects with read-write permissions on startup
    However, this approach would prevent on-cluster updates to the git credentials from automatically propagating to the workspace, which is a requirement (see: Update how personal access token git credentials are mounted into workspaces #915)

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant