Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set CPU limits by default unless they are required by a LimitRange #1126

Open
amisevsk opened this issue Jun 14, 2023 · 0 comments
Open
Assignees
Labels
good first issue Good for newcomers

Comments

@amisevsk
Copy link
Collaborator

Description

We've gotten a number of requests to not set CPU limits by default on containers. By default there is no CPU limit or request for sidecar containers, however for project-clone we do set a default CPU Limit of 1000m unless otherwise specified.

If a namespace does not include a limitRange that may require a CPU Limit to be set, we should not set one by default. If the DevWorkspaceOperatorConfig specifies a non-default CPU limit, we should use that value

Additional context

Related: eclipse-che/che#22198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants