Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tags used for images (:ci instead of :next) #401

Closed
amisevsk opened this issue Apr 28, 2021 · 9 comments
Closed

Update tags used for images (:ci instead of :next) #401

amisevsk opened this issue Apr 28, 2021 · 9 comments

Comments

@amisevsk
Copy link
Collaborator

Description

Currently, we use the following tags for DWO-related images:

  • next is used for per-commit builds (i.e. on the day of release, next becomes currently released version)
  • vX.Y.Z is used for released versions
  • latest is not used and has never been pushed

We should review this and define a scheme going forward. Note that Eclipse Che has a similar issue open (eclipse-che/che#19291) that suggests using ci as the per-commit build tag -- I'm not a huge fan of that approach since to me ci suggests that it's an image used for CI rather than produced by CI.

@nickboldt
Copy link
Collaborator

nickboldt commented Apr 30, 2021

if not ci then is nightly better ?

Product convention in CRW is:

  • nightly for CI builds based on master/main/crw-2-rhel-8 bleeding edge branches
  • latest for release candidates / releases based on 7.yy.x/crw-2.y-rhel-8 stable branches
  • 2.y floating tags for BOTH nightlies and latest
  • prefix v is not used anywhere (why is it needed anyway? golang or npm requirement?)

@benoitf
Copy link
Collaborator

benoitf commented Apr 30, 2021

nightly is not a good choice when it's not done at night but After every commit

And ci I don't know what it means. Like is it used by CI jobs ? When is it done ?

@nickboldt
Copy link
Collaborator

nickboldt commented Apr 30, 2021

Instead of saying no to everything I suggest, could you suggest something better?

CI = continuous integration. when is it done? continuously on every commit. how is it used? yes, by CI jobs. The ones that check PRs, build it on merge, test it w/ e2e tests, generate reports, etc.

@benoitf
Copy link
Collaborator

benoitf commented Apr 30, 2021

Instead of saying no to everything I suggest, could you suggest something better?

I like next (but I already said that I think) because it let me think it's what is coming up next

Also in chectl there are two channels: stable and next

so if I use chectl with next channel, and that images are using next tag I'm not lost

@JPinkney
Copy link
Contributor

What if we just used the branch name as the tag? So quay.io/devfile/devworkspace-controller:main would just be the image created by the latest changes in main

@nickboldt
Copy link
Collaborator

nickboldt commented Apr 30, 2021

once all repos have migrated to main (instead of master) then yeah, that could work too. similar to downstream convention of having a floating tag for the stable branch, you could also have a v0.3.x or v0.4.x label for builds from the stable branch (to differentiate builds tagged from the main branch)

If everyone agrees on what next means and we use it in ALL projects, then I'm good with that one too. The point of ci was to avoid the 'I like nightly' camp and the 'I like next' camp from arguing over which was better. :) but if everyone consistently hates ci and we can get quorum on :next or :main then that's fine. I was just looking for consistency of convention (in eclipse-che/che#19291 )

@benoitf
Copy link
Collaborator

benoitf commented Apr 30, 2021

I prefer main or next over ci
we're using main for plugin registry artifacts coming : https://che-plugin-registry-main.surge.sh/v3/plugins/

It was to have consistency with next channel ofchectl but it might be changed here as well

@nickboldt
Copy link
Collaborator

If the plugin registry currently uses machine exec nightly, theia next, and main.surge, it's a bad example of how to do things consistently. ;)

here's my updated proposal from eclipse-che/che#19291 (comment)

image

Would that satisfy everyone?

@sleshchenko
Copy link
Member

Seems DWO has nothing to do with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants