Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit max length of numInputs #1

Closed
ajayns opened this issue Jun 9, 2018 · 4 comments
Closed

Limit max length of numInputs #1

ajayns opened this issue Jun 9, 2018 · 4 comments

Comments

@ajayns
Copy link
Contributor

ajayns commented Jun 9, 2018

Current plan is to restrict it to 10

@ojaswa1942
Copy link

Do you also plan to enforce a minimum number of numInputs?

@ajayns
Copy link
Contributor Author

ajayns commented Oct 3, 2019

@ojaswa1942 Hey! As of now, we haven't exactly planned what the limits should be. So it would be great if you could share the logic behind setting a particular limit as well. :)

@ojaswa1942
Copy link

ojaswa1942 commented Oct 3, 2019

Presently we can also pass 0 and negative values to numInputs and that results in a no input fields at all.. It'd be good if a minimum default is rendered for invalid values of numInputs. The same can be done for high values of numInputs and a default maximum number, say 10 can be used instead

  • Screenshot for numInputs = 0
    Screenshot for numInputs = 0

  • Screenshot for numInputs = 178
    Screenshot for numInputs = 178

@nikhilgupta30
Copy link
Contributor

this pull request restricts the length of numInput
#66
@ajayns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants