Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo Feature using ctrl + Z shortcut #139

Open
manjots1607 opened this issue Oct 1, 2020 · 6 comments
Open

Undo Feature using ctrl + Z shortcut #139

manjots1607 opened this issue Oct 1, 2020 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@manjots1607
Copy link

  • Feature Description
    Currently, if we press ctrl+z nothing happens, in every text input we have this feature, especially come handy when we
    paste wrong otp..

  • Preferred Solution

    • Needed to create Globale undo Stack to store all values.
    1. Create keydown event for ctrl + z, that pop out element from undostack and set new value.
    2. Code contains method handleOtpChange inside that push (this.props.value) every time it triggers.

Tried to implement this algorithim and also initiating PR in a while.

@sauravsolanki
Copy link

@manjots1607 Please assign me this.

@manjots1607
Copy link
Author

I have already done PR to this, but @sauravsolanki you can look into my PR and if you find something missing, you can contributing by giving suggestion in that discussion group.

@manjots1607
Copy link
Author

@apollonian @ajayns Please look this issue.....

@manjots1607
Copy link
Author

@apollonian @ajayns Any Updates...????

@apollonian apollonian added the enhancement New feature or request label Oct 31, 2020
@apollonian
Copy link
Contributor

Thanks for the suggestion! At the moment, it feels a little out of scope to me, but if we get more requests, I'd be happy to bump this up in the priority list.

@MshHooman
Copy link

MshHooman commented May 28, 2022

need too

@prateek3255 prateek3255 added the good first issue Good for newcomers label Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants