Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media files #5

Open
norm opened this issue Jun 27, 2020 · 2 comments
Open

Media files #5

norm opened this issue Jun 27, 2020 · 2 comments

Comments

@norm
Copy link
Member

norm commented Jun 27, 2020

Dr Syntax states "Media files are referenced..." but is silent about how they appear in the recipe. My suggestion would be a media array that can be attached to the recipe as a whole or an individual step, each entry being an object containing the path to the media and optional extra keys (width, height, alt text, HTML class to apply...).

@jaylett
Copy link
Member

jaylett commented Jun 27, 2020

I think that's sensible. If it's media, that suggests more than pictures. Would you support audio, for instance? (And if so, would it make sense to support this at top-level, and/or alongside text blob keys? Possibly that would require objects for textblobs + audio, textblobs + video, &c.)

@norm
Copy link
Member Author

norm commented Jun 27, 2020

I would think that attached media could be anything and that Dr Syntax should be agnostic as to how it works, but provide some common examples. Photo, audio, video being the most likely to my mind.

I can whip up a PR for criticism purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants