Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Devhub 3.0.0 #81

Merged
merged 105 commits into from Apr 20, 2015
Merged

Devhub 3.0.0 #81

merged 105 commits into from Apr 20, 2015

Conversation

jwgmeligmeyling
Copy link
Member

Finally this is the Devhub 3.0.0 pull request. I managed to get all the existing integration tests to work. However, it involved some quite deep nested mocking, so we should probably have a look at this. I also did a smoke test after the rebase. We should however, first do some more testing / review before deployment.

Changelog

  • The current User and Group are now injected into the @RequestScoped resources. This deduplicates logic checking if the user is allowed to view project information for the current group.
  • The Selenium Firefox driver is updated to the newest version

Features

  • Ability to create Pull Requests for branches
  • Ability to merge pull requests into the master branch
  • Ability to create/update courses
  • Ability to create/update assignments for courses
  • A student can submit deliveries for assignments
  • Assistants and administrators can review assignment deliveries
  • Assistants can be added to / removed from courses
  • Ability to add comments to pieces of code for review (files, diffs, pull requests)

Deployment notes

Jan-Willem Gmelig Meyling added 30 commits March 31, 2015 23:26
Work still needs to be done to:
 - comment from file view
 - view comments from multiple commits (branches, pull requests)

#62
The way to show comments on an older commit in a pull request diff frightens me a bit.

Changes to be committed:
	modified:   src/main/java/nl/tudelft/ewi/devhub/server/backend/GitBackend.java
	new file:   src/main/java/nl/tudelft/ewi/devhub/server/web/resources/CommentBackend.java
	modified:   src/main/java/nl/tudelft/ewi/devhub/server/web/resources/ProjectResource.java
@jwgmeligmeyling
Copy link
Member Author

Finally I have managed to get through all the small tweaks, bugs and new feature request. Not only can we add inline comments, we can also add comments to the scope of a pull request or commit. Grades can now be downloaded. The tests pass and the test environment has been redeployed.

Ready for deployment! @michaeldejong

[#else]
<tr>
<td class="muted">
No unmerged pull requests in this repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "No closed/merged pull requests in this repository." as you can have unmerged pull requests, but they don't show up in this table.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this atm.

@jwgmeligmeyling
Copy link
Member Author

On hold for two small fixes (estimate 2 hours for fix + full pass)

@jwgmeligmeyling
Copy link
Member Author

Fixed the issues and redeployed the test environment.

Type(type = org.hibernate.type.TextType) annotations
@jwgmeligmeyling
Copy link
Member Author

Added the @Type(type = "org.hibernate.type.TextType") annotations to the entity classes to work properly with Postgres. I say properly because it already worked under Postgres, but after querying the database through psql I found that the TEXT fields were stored as blobs and showed up as numbers. I have tried various variants on the web, with/without @Lob, @Basic, and the newer @Type(type="org.hibernate.type.StringClobType"). Even more difficult was getting it to work under H2.

For now this seems to be the only way to go:

  • Annotate TEXT types with @Type(type = "org.hibernate.type.TextType")
  • Run H2 under PostgreSQL mode and use a Postgres dialect for Hibernate.

Redeployed the test environment, but dropped the existing schema.

@jwgmeligmeyling
Copy link
Member Author

Fixed merge conflict for @Type(type = "org.hibernate.type.TextType").

michaeldejong added a commit that referenced this pull request Apr 20, 2015
@michaeldejong michaeldejong merged commit 0c63d77 into master Apr 20, 2015
@jwgmeligmeyling jwgmeligmeyling deleted the git-client-refactor branch January 19, 2016 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants