Conversation
Work still needs to be done to: - comment from file view - view comments from multiple commits (branches, pull requests) #62
The way to show comments on an older commit in a pull request diff frightens me a bit. Changes to be committed: modified: src/main/java/nl/tudelft/ewi/devhub/server/backend/GitBackend.java new file: src/main/java/nl/tudelft/ewi/devhub/server/web/resources/CommentBackend.java modified: src/main/java/nl/tudelft/ewi/devhub/server/web/resources/ProjectResource.java
Finally I have managed to get through all the small tweaks, bugs and new feature request. Not only can we add inline comments, we can also add comments to the scope of a pull request or commit. Grades can now be downloaded. The tests pass and the test environment has been redeployed. Ready for deployment! @michaeldejong |
[#else] | ||
<tr> | ||
<td class="muted"> | ||
No unmerged pull requests in this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to "No closed/merged pull requests in this repository." as you can have unmerged pull requests, but they don't show up in this table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing this atm.
On hold for two small fixes (estimate 2 hours for fix + full pass) |
Moved text from templates to translation file
Fixed the issues and redeployed the test environment. |
Type(type = org.hibernate.type.TextType) annotations
Added the For now this seems to be the only way to go:
Redeployed the test environment, but dropped the existing schema. |
Fixed merge conflict for |
db695ff
to
b550213
Compare
Finally this is the Devhub 3.0.0 pull request. I managed to get all the existing integration tests to work. However, it involved some quite deep nested mocking, so we should probably have a look at this. I also did a smoke test after the rebase. We should however, first do some more testing / review before deployment.
Changelog
User
andGroup
are now injected into the@RequestScoped
resources. This deduplicates logic checking if the user is allowed to view project information for the current group.Features
Deployment notes
/etc/devhub-server/storage/