New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undo grey scale #32
Comments
closed as i made a new, broader issue |
ths doesnt work? @devhyper im confused, i thought you said we had non-destructive editing |
|
ahhh, hitting greyscale itself doesnt undo it so i assume it's basing it off of a timeframe. regardless, theres no way to undo the greyscale mid-video. so if i greyscale at 5 seconds and then want to colorscale at 12 seconds i cant. does that make sense? |
ignore this, it is non-destructive |
like yk how you hit invert colors again and it goes back to normal, but grey doesnt. either have everything work as i described above or have it do as you do with the invert colors, having two standards is bad |
Yeah sorry for the confusion. When you click the filter twice it will just apply the filter again, so invert colors just inverts the already inverted colors back. I'll leave it as is now, because when composition previewing lands in Media3, I will implement the ability to specify filter lengths. This will also allow for the grayscale certain part and invert certain part you mentioned. |
when will that be implemwnted and what is it simply? |
Basically the app uses the Android Media3 library as a backend to process and play the video. Currently, the library has this thing called Composition, which allows adding multiple videos together, cutting them into segments, adding effects to certain segments, etc. However the player in the library cannot play this composition yet, they are working on it in their main branch though. My guess is that it will come in their library version 1.4. |
how can yoy put stuff in the next milestone if thatll take months to come out |
The stuff in the milestones don't require composition. Everything that does is tracked by #55 |
please design filters non-destructively until export
The text was updated successfully, but these errors were encountered: