Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device.description returns wrong values #301

Open
mklschreiber opened this issue Oct 21, 2021 · 2 comments
Open

Device.description returns wrong values #301

mklschreiber opened this issue Oct 21, 2021 · 2 comments

Comments

@mklschreiber
Copy link

The current version returns different values for know devices. If I'm using an iPhone XR in combination with the API Device.description I'm getting the result "iPhone XR". If I'm using an iPhone 12 Pro the Device.description returns the value "iPhone13,3".

We checked the enum but didn't see the error. Could you please check it?

@Zandor300
Copy link
Member

That means that the library version that you are using doesn't have iPhone 12 Pro support. Which version of DeviceKit are you using? iPhone 12 series support was added in version 4.2.0, the latest version is 4.5.2.

pod 'DeviceKit', '~> 4.5'

@mklschreiber
Copy link
Author

we are using the version 4.5.1 which should support those models... I added a workaround in my project by checking your string for the pattern (iPhone|iPad)XX,X and then switching to the known cases provided by your enum. Therefore the devices are known for the lib but the value returned to our application is wrong...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants