Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps (CircleCI): build step to publish latest version on Github Pages #165

Closed
rjlopezdev opened this issue May 9, 2019 · 10 comments · Fixed by #229 or #394
Closed

DevOps (CircleCI): build step to publish latest version on Github Pages #165

rjlopezdev opened this issue May 9, 2019 · 10 comments · Fixed by #229 or #394
Labels
devops Use this label for devops related enhancements enhancement

Comments

@rjlopezdev
Copy link
Contributor

I've noticed Devicon Web is not updated with the latest icons.

I could design a simple CI cycle to atomate this proccess:

Steps

  • First: build static files
  • Second: commit new version to gh-pages branch

Triggers

  • Commiting over master branch

If you are interested, I would need the scripts you use to publish on gh-pages 🙏

@konpa
Copy link
Collaborator

konpa commented May 9, 2019

There is none... I want to automate the process (as well as the one to generate the font files) for a long time but never took the time to do it... For now, gh-pages is just an Angular SPA with master branch as submodule.

@rjlopezdev
Copy link
Contributor Author

Ouh! I see...
I could work on this first:

  • Rewriting old angular.js app into a new Angular 7.
  • Script to read fonts directory to parse it & generate a JSON with new additions.

Once this is done, build CI cycle.

If you agree that, I could work on it.
Unless, I'll close this issue.

@konpa
Copy link
Collaborator

konpa commented May 9, 2019

Yes sure, would be great !

@amacado amacado added enhancement devops Use this label for devops related enhancements labels Jun 8, 2020
@amacado
Copy link
Member

amacado commented Jun 8, 2020

@rjlopezdev are u still interested in contributing? Because an automated build process including the font generation would be amazing.

@rjlopezdev
Copy link
Contributor Author

Sure! Please, can you explain me the build process in order to I can reply it & automate It? @amacado 🙏

@amacado
Copy link
Member

amacado commented Jun 10, 2020

I'm working on a document explaining the build process. Update here as soon it's ready

@rjlopezdev
Copy link
Contributor Author

Awesome! Eager to read it!

@amacado amacado linked a pull request Jun 10, 2020 that will close this issue
@amacado
Copy link
Member

amacado commented Jun 10, 2020

I just published the first version of the documentation in my fork. Feel free to take a look at it and enhance it. I also upgraded to gulp v4 in this pull request, since gulp 3 is not compatible with current node version.

I think the main challenge for build automation is the icomoon.app (maybe there is an api?) and we would need to refactor the 'alias'-idea in the stylesheets.

@amacado amacado reopened this Jun 11, 2020
@amacado
Copy link
Member

amacado commented Sep 7, 2020

I'm thinking of integrating the gh-pages branch into the master branch so we do not face the issue of keeping the two branches up to date anymore, any thoughts of this?

@amacado amacado linked a pull request Dec 15, 2020 that will close this issue
@amacado amacado mentioned this issue Dec 15, 2020
@amacado
Copy link
Member

amacado commented Jan 3, 2021

Since v2.8.0 we are publishing the devicon.dev from the master branch (docs/) it's always up to date with the most recent changes.

@amacado amacado closed this as completed Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants