Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: split up devicon.json #2136

Open
1 task done
weh opened this issue Feb 7, 2024 · 4 comments
Open
1 task done

[FEATURE REQUEST]: split up devicon.json #2136

weh opened this issue Feb 7, 2024 · 4 comments
Labels
awaiting triage Awaiting triage from a maintainer discussion Use this label for community discussions about changes/features/.. enhancement

Comments

@weh
Copy link
Contributor

weh commented Feb 7, 2024

I have searched through the issues and didn't find my problem.

  • Confirm

Description

I had this idea before, and was reminded by the check-bot comment in #2135
I am not sure if this works for the whole build and release process, so i guess this needs more input.

The Idea:
Split up the devicon.json into snippets for each icon. So instead of having one huge json, split it up into a "one json per icon"
So in the example case of the teleport icon, we would have a folder like the following:

image

So each icon folder also includes a devicon.json or teleport.json (whatever fits better), including only the part specific for this icon.

When ever the full devicon.json is needed for build or publish it could be merged with a tool like jq or similar,
by iterating over all icon folders, and therefore automatically produce the alphabetical order we want.

Context

I think the pro side of this split up is, that the contributors, don't need to have to remember that the alphabetical order is needed.

Possible Solution

No response

Additional information

No response

@Yashh56
Copy link
Contributor

Yashh56 commented Feb 7, 2024

then what about the devicon.json that are using now?

@weh
Copy link
Contributor Author

weh commented Feb 7, 2024

then what about the devicon.json that are using now?

in a inital step, we would need to split the current single devicon.json into multiple parts, and add them to the icon folders.

@Yashh56
Copy link
Contributor

Yashh56 commented Feb 7, 2024

Should I work on this issue?

@weh weh added the discussion Use this label for community discussions about changes/features/.. label Feb 7, 2024
@weh
Copy link
Contributor Author

weh commented Feb 7, 2024

i think this needs more input from the project team, specially the people who are familiar with the build / publish part.
so currently this is more a idea/discussion thing. and not (yet) ready for some implementation.

@weh weh added the awaiting triage Awaiting triage from a maintainer label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage Awaiting triage from a maintainer discussion Use this label for community discussions about changes/features/.. enhancement
Projects
None yet
Development

No branches or pull requests

2 participants