Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-Update latest version (tagging) in GitHub Page (including CDN link) #395

Closed
amacado opened this issue Dec 15, 2020 · 3 comments · Fixed by #401
Closed

Auto-Update latest version (tagging) in GitHub Page (including CDN link) #395

amacado opened this issue Dec 15, 2020 · 3 comments · Fixed by #401
Assignees
@amacado
Labels
devops Use this label for devops related enhancements enhancement

Comments

@amacado
Copy link
Member

amacado commented Dec 15, 2020

When a new version is beeing released it should auto update the version number which is shown on the GitHub page. Currently it has to be updated manually. I would also suggest to update the CDN links for pointing to a specific version instead of the master branch. This is recommended as best practices because when someone uses the CDN it should not be "auto updated" in the background which could cause Incompatibility (see discussion #391).

image

I think it should be possible to use the GitHub REST API for that: https://docs.github.com/en/free-pro-team@latest/rest/reference/repos#list-repository-tags
@amacado amacado added enhancement devops Use this label for devops related enhancements labels Dec 15, 2020
@amacado amacado self-assigned this Dec 15, 2020
@amacado
Copy link
Member Author

amacado commented Dec 15, 2020

I will work on this issue in the upcoming week.

@amacado amacado mentioned this issue Dec 15, 2020
Merged
@amacado amacado mentioned this issue Dec 28, 2020
Merged
@amacado amacado linked a pull request Dec 28, 2020 that will close this issue
fix gh-page in master branch / enhance auto-versioning #401
Merged
@Thomas-Boi
Copy link
Member

Closing this issue since #401 is already merged

@amacado
Copy link
Member Author

amacado commented Dec 31, 2020

@Thomas-Boi it will auto-close once merged into master ;-)

@amacado amacado mentioned this issue Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amacado amacado

Labels
devops Use this label for devops related enhancements enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix gh-page in master branch / enhance auto-versioning devicons/devicon
2 participants
@amacado @Thomas-Boi