Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some svg icons don't have colors #63

Closed
eden-lane opened this issue Jun 17, 2017 · 2 comments · Fixed by #328
Closed

Some svg icons don't have colors #63

eden-lane opened this issue Jun 17, 2017 · 2 comments · Fixed by #328
Assignees
@iamclaytonray
Labels
bug Use this label for pointing out bugs

Comments

@eden-lane
Copy link

Some icons have attribute fill (angular's icon for example), but some of them don't. For example, webpack's icon has attribute class cls-1 instead of fill. Is it intended?
@oligibson
Copy link
Contributor

@eden-lane thanks for raising, this isn't intended behaviour. I will look at this when I get a chance.

@oligibson oligibson self-assigned this Jun 17, 2017
@unigazer
Copy link

unigazer commented Aug 20, 2017 •
edited

Facebook svg and React don't have the blue background, Twitter also.

@iamclaytonray iamclaytonray added the bug Use this label for pointing out bugs label Dec 16, 2018
@amacado amacado mentioned this issue Oct 18, 2020
Merged
@amacado amacado linked a pull request Oct 18, 2020 that will close this issue
fix svg rendering in preview window for showing the svg code #328
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamclaytonray iamclaytonray

Labels
bug Use this label for pointing out bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix svg rendering in preview window for showing the svg code devicons/devicon
4 participants
@eden-lane @oligibson @unigazer @iamclaytonray