Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend guidelines to avoid mis-matched icon layouts #70

Closed
Chippd opened this issue Aug 8, 2017 · 2 comments
Closed

Amend guidelines to avoid mis-matched icon layouts #70

Chippd opened this issue Aug 8, 2017 · 2 comments
Labels
enhancement question Use this label for general questions not covered by another label

Comments

@Chippd
Copy link
Contributor

Chippd commented Aug 8, 2017

I want to use the icons in this repo programatically, but I'm getting awkward results, visually I mean. See screenshot. The "plain-wordmark" icons aren't all the same structure in that some have the icon to the left of the word, and some have it above. I think an update to the guidelines to specify that the wordmark should be one or the other (whatever is most prevalent currently within the repo). I can submit a PR with my ideas if that makes sense.

http://imgur.com/6nGq5pK

Thank you all for the work, it's a great resource.

@iamclaytonray iamclaytonray added enhancement question Use this label for general questions not covered by another label labels Dec 16, 2018
@iamclaytonray
Copy link
Contributor

Hey @Chippd! Thanks for your question!

How would you handle this? Some of the icons are intentionally designed like that because that's the original design of those icons. For example, the Angular icon reads left to right while others are above/below/etc. I'd definitely love to see all icons consistent but not sure how to approach that issue.

@Thomas-Boi
Copy link
Member

I'll be closing this issue since there's no new comments on it. If someone comment, I'll reopen this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement question Use this label for general questions not covered by another label
Projects
None yet
Development

No branches or pull requests

3 participants