Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Editor thinks VRAM is byte-addressed #332

Open
jeffythedragonslayer opened this issue Jun 27, 2022 · 4 comments
Open

Memory Editor thinks VRAM is byte-addressed #332

jeffythedragonslayer opened this issue Jun 27, 2022 · 4 comments
Labels

Comments

@jeffythedragonslayer
Copy link
Contributor

When the Memory Editor is viewing S-PPU VRAM, there are 16 bytes per row. The second row is labeled "0010" (which is hex for 16) which means that this Memory Editor window is displaying the VRAM as byte-addressed. But the SNES has word-addressed VRAM. The "Address:" label in the bottom panel has the same problem.

image

@jeffythedragonslayer
Copy link
Contributor Author

The Address field and Selected Tile Address label in the Tile Viewer also have this problem.

@devinacker
Copy link
Owner

This has always been intentional - partly just to make VRAM addressing consistent with everything else, and also since VRAM is still read/written as bytes instead of words behind the scenes.

I think it wouldn't be a bad idea to have an option to use word addressing for VRAM instead, but I'd probably make it non-default just to avoid breaking the existing convention.

@devinacker devinacker added the ui label Jun 29, 2022
@jeffythedragonslayer
Copy link
Contributor Author

jeffythedragonslayer commented Jun 29, 2022

Does that default of byte-addressing make anyone's workflow easier? I think keeping it byte-addressed makes it harder for people developing games because the addresses they're seeing aren't what they need to set VMADDL and VMADDH to in order to read/write VRAM.

@Ramsis-SNES
Copy link

I agree with @jeffythedragonslayer. At least an option to have VRAM word addressing in bsnes-plus would make things sooooo much less confusing, and more consistent, with a reasonably normal programming/debugging workflow. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants