Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revenue chart should show current year #159

Closed
benjamincoleman opened this issue Apr 3, 2020 · 5 comments
Closed

Revenue chart should show current year #159

benjamincoleman opened this issue Apr 3, 2020 · 5 comments
Assignees
Milestone

Comments

@benjamincoleman
Copy link
Collaborator

Screenshot 2020-04-03 at 12 29 18

We should see the column for 2006 highlighted on the chart below to indicate the period we are looking at.

@k8hughes
Copy link
Collaborator

k8hughes commented Apr 3, 2020

So are we saying this chart should have the line to show the change over time as well as a bar for the distinct date?

@k8hughes k8hughes added this to Backlog in Building the Spotlights via automation Apr 3, 2020
@benjamincoleman
Copy link
Collaborator Author

So are we saying this chart should have the line to show the change over time as well as a bar for the distinct date?

Yes, you currently see this if you hover over that chart:

Screenshot 2020-04-03 at 13 44 31

And I described this function in the sketches:

Screenshot 2020-04-03 at 13 47 45

@k8hughes
Copy link
Collaborator

k8hughes commented Apr 3, 2020

@edwinmp will this be hard to implement? It would be good to do if it isn't complex...

@edwinmp
Copy link
Collaborator

edwinmp commented Apr 3, 2020

Will be tricky for the line chart, but will figure it out. Shouldn't be a problem to set the drop-down & tree-map to the latest year.

@edwinmp edwinmp moved this from Backlog to In Progress in Building the Spotlights Apr 7, 2020
@edwinmp edwinmp self-assigned this Apr 7, 2020
@edwinmp edwinmp added this to the v0.6.0 milestone Apr 7, 2020
@edwinmp edwinmp linked a pull request Apr 7, 2020 that will close this issue
@edwinmp edwinmp removed a link to a pull request Apr 8, 2020
@edwinmp edwinmp modified the milestones: v0.6.0, v0.5.0 Apr 8, 2020
@edwinmp edwinmp moved this from In Progress to Functional Review in Building the Spotlights Apr 8, 2020
@k8hughes
Copy link
Collaborator

k8hughes commented Apr 8, 2020

LGTM.

@k8hughes k8hughes closed this as completed Apr 8, 2020
Building the Spotlights automation moved this from Functional Review to Done Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants