TKCalendarMonthView no longer supports Monday as the first weekday

[muhku]

In some regions Monday should be the first weekday. TKCalendarMonthView no longer supports this, in TKCalendarMonthView.h:

• (id) initWithSundayAsFirst:(BOOL)sunday; // it sunday regardless right now...

[devinross]

I just haven't had time to implement this. Maybe you could help contribute? I kinda left a trail so it could be added in later.

[nihilenz]

I tried to change this way. It seems to work, but I advise you to check.

File: TKCalendarMonthView.m
There are two invocations of initWithMonth in which startDayOnSunday must be changed from YES to sunday (and then you can dinamically get the firstWeekday from current calendar and call initWithSundayAsFirst in init)

File: TKCalendarMonthTiles.m
I changed initWithMonth and rangeOfDatesInMonthGrid as http://gist.github.com/537603

[muhku]

@nihilenz: Thanks! I tested the change and I didn't find problems.

I made one further change. To make sure the calendar view is initialized by the current calendar format, change the init method of TKCalendarMonthView.m: http://gist.github.com/543456

[muhku]

All changes in one patch: http://gist.github.com/543469

Please review.

[muhku]

Sorry, more testing revealed the patch actually doesn't work. When touching a day, the month grid doesn't correctly calculate the day, which was selected. But let's see if I can fix it.

[nihilenz]

D'ho! I had not noticed at all...
I edited http://gist.github.com/537603 to add a modification to replace the lines [5-15] of reactToTouch

[muhku]

@nihilenz: Haha, I was about to submit a pretty similar fix ;-) Anyways, I'll make a new patch with your version...

[muhku]

@nihilenz: the following if

if(row==0 && column < firstWeekday-2){

doesn't change the previous month correctly if the first weekday of a month is Sunday (like now in August 2010).

I decided to use my own version, which looks a bit different, but feel free to make your own patch...

Anyways, the version which works for me is here: http://gist.github.com/543607

Please review again.

[nihilenz]

Right!
Your version works fine ;)

[devinross]

Good work! Do you know a way to easily merge these changes back into the framework?

[muhku]

@devinross: Just copy the patch to the root directory of the library and merge it:

patch -p1 < foo.diff

-p1 tells patch to ignore the first path element so it works in the root dir.