Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODCalendarDayTimelineView #24

Closed
nobre84 opened this issue Oct 29, 2010 · 4 comments
Closed

ODCalendarDayTimelineView #24

nobre84 opened this issue Oct 29, 2010 · 4 comments
Labels

Comments

@nobre84
Copy link

nobre84 commented Oct 29, 2010

Hi! This is an excellent library! You have a couple issues on this component tho.

  1. There is no title with the current day, next and previous buttons
  2. The balloons will clutter up one on top of the other, and won't offset when they overlap (when one appointment begins before another ends, the iPhone will offset them a little to the right)
  3. The hour field on the timeline is always Am/Pm based, instead of configurable

I have fixed those issues, how can I post it back to merge them with the library?

@nobre84
Copy link
Author

nobre84 commented Oct 29, 2010

I created an uniffied diff and put it here on github (I'm new here, don't know how easy it is for you to check them out and incorporate into the library)
Here is the patch http://gist.github.com/654357

I'm still looking into another issue that is drawing the Appointment title and location text in a word-wrappable way instead of just truncating, if there is space available in the bubble.

@nobre84
Copy link
Author

nobre84 commented Nov 3, 2010

New diff that improves the drawing to 5min accuracy in the timeline (with the default minimum 30minutes respected). And also a delegate method for capturing double taps in the timeline for the developer to implement something useful (i.e add an event on the tapped hour)
https://gist.github.com/661473

@nobre84
Copy link
Author

nobre84 commented Nov 25, 2010

Hi, have you seen my private message with the code you requested ?
One more thing , ODCalendarDayTimelineView is retaining its delegate, causing a retain cycle that prevents it from being freed!
Regards
nobre

@devinross
Copy link
Owner

About to commit changes.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants