Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor paranoid_verification #206

Open
olbrich opened this issue May 16, 2020 · 0 comments
Open

Refactor paranoid_verification #206

olbrich opened this issue May 16, 2020 · 0 comments

Comments

@olbrich
Copy link
Contributor

olbrich commented May 16, 2020

We want to perform a general cleanup of many of our modules before you move to 1.0.

While there may be more issues with this particular module, a good starting point is to check the following:

  • Are there any Rubocop violations we can fix?
  • Are there practices we use elsewhere, but not in this module (e.g., ActiveSupport::Concern)?
  • Can we improve the documentation (especially adding Yardocs)?

This can be taken in smaller pieces (e.g., one PR for documentation, another to use ActiveSupport::Concern, etc.) if it's easier to manage.

@olbrich olbrich added this to the 1.0.0 milestone May 16, 2020
@tmr08c tmr08c added the Hacktoberfest Issues that are good new contributors to help with as a part of Hacktoberfest label Oct 4, 2020
@tmr08c tmr08c removed the Hacktoberfest Issues that are good new contributors to help with as a part of Hacktoberfest label Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants