Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for envoyproxy/protoc-gen-validate #42

Closed
k1ng440 opened this issue Aug 13, 2021 · 5 comments
Closed

Add support for envoyproxy/protoc-gen-validate #42

k1ng440 opened this issue Aug 13, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@k1ng440
Copy link

k1ng440 commented Aug 13, 2021

Thank you for writing this plugin, its mostly works except its throws error while using rules for envoyproxy/protoc-gen-validate

https://puu.sh/I3FGh/d1e225ec2d.png

thanks

@devkanro
Copy link
Owner

My syntax not support multi field name in options
Like this:

option (myOptions).field1.field2 = "";

Support this:

option (myOptions).field1 = { field2 : "" };

I will try to add it in next version.

@devkanro devkanro added the enhancement New feature or request label Aug 19, 2021
@devkanro
Copy link
Owner

Fixed in 1.4.3

@devkanro
Copy link
Owner

I have fixed it in 1.4.3, could you delete your low rating review in Jetbrains Plugins?

https://plugins.jetbrains.com/plugin/16422-protobuf/reviews#review=58139

@k1ng440
Copy link
Author

k1ng440 commented Aug 23, 2021

done. written a new review. thanks

@devkanro
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants