Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB theme is no longer RGB #147

Closed
devkennyy opened this issue Jul 28, 2022 · 10 comments · Fixed by #148
Closed

RGB theme is no longer RGB #147

devkennyy opened this issue Jul 28, 2022 · 10 comments · Fixed by #148
Labels
good first issue Beginner friendly issues. You do not need permission to work on these. rungeon: theme Changes to themes and/or the system scope: frontend Frontend related changes type: bug Issues that need priority attention.

Comments

@devkennyy
Copy link
Owner

The RGB theme doesn't actually make any of the stage content RGB. The selectors are there but there's obviously a problem.

#index.theme-rgb .nav-link,
#index.theme-rgb .stage .icon,
#index.theme-rgb .doors i,
#index.theme-rgb .links i,
#index.theme-rgb #themePopup,
#index.theme-rgb #themePopup #closeButton {
  animation: rgb 5s linear infinite !important;
}
@devkennyy devkennyy added good first issue Beginner friendly issues. You do not need permission to work on these. scope: frontend Frontend related changes rungeon: theme Changes to themes and/or the system type: bug Issues that need priority attention. labels Jul 28, 2022
@Shabbyconnor
Copy link
Collaborator

It appears that the CSS applied to the "stage" class is overwriting the RGB. Turn it off and we get the RGB. However, the CSS is reasonable for applying the rest of the themes so I'll have to figure something out

@Shabbyconnor
Copy link
Collaborator

Kay. I've got a fix. Remind me what RGB is supposed to look like. Does the text need to be RGB too? How about the continue button?

@devkennyy
Copy link
Owner Author

devkennyy commented Jul 28, 2022

There's an RGB animation, you just need to apply it to the stage icon and whatever else looks good (maybe the navbar icons?).

@Shabbyconnor
Copy link
Collaborator

Originally it looked like this:
Screen Shot 2022-07-28 at 4 10 33 PM
I can make it look like that, or I can go more intense and make it look like this:
Screen Shot 2022-07-28 at 4 17 36 PM
What do you think?

@devkennyy
Copy link
Owner Author

This is definitely nicer, if you want rgb, you're getting rgb :trollface:

@gruelingpine185
Copy link
Collaborator

@Shabbyconnor Was it intentional to have the elements and icons changing colors unsynchronized?

@Shabbyconnor
Copy link
Collaborator

Shabbyconnor commented Jul 29, 2022

No, but I'm not sure of a way to sync them up.
The problem is the animation starts at the beginning when a new element is created. Some elements on the page never change like the navbar. But some like the text and icon change every time the stage switches. Causing the RGB animation to reset, and become out of sync

@gruelingpine185
Copy link
Collaborator

Oh. So since only the icon and the prompt changes every stage switch, could it be possible to make a function that captures stage switches and removes and replaces the rgb animation? The transition between stages might be a bit rough, but at least the colors are synced

@Shabbyconnor
Copy link
Collaborator

Yeah. You'd have to replace the animation for each element though.

@Shabbyconnor
Copy link
Collaborator

@Shabbyconnor Was it intentional to have the elements and icons changing colors unsynchronized?

Fixed by #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Beginner friendly issues. You do not need permission to work on these. rungeon: theme Changes to themes and/or the system scope: frontend Frontend related changes type: bug Issues that need priority attention.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants