Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme popup modifications. #90

Closed
devkennyy opened this issue Jul 18, 2022 · 6 comments
Closed

Theme popup modifications. #90

devkennyy opened this issue Jul 18, 2022 · 6 comments
Labels
good first issue Beginner friendly issues. You do not need permission to work on these.

Comments

@devkennyy
Copy link
Owner

image

The bottom margin should be increased and the height should be increased by roughly 1 pixel. Overall, this needs to be more responsive in case we add more popups. Maybe we should remove all the icons on the page? Would love to hear suggestions.

image

@devkennyy devkennyy added enhancement good first issue Beginner friendly issues. You do not need permission to work on these. labels Jul 18, 2022
@knight-95
Copy link
Contributor

knight-95 commented Jul 18, 2022

I guess removing icons is not a good idea instead, we can work on adjusting the size of the content/margin

@knight-95
Copy link
Contributor

I would like to work upon this issue.

Below I have added an updated solution, that would fix this.
If in the future we want to add extra labels then we can have a drop-down menu. I am working on that too

Screenshot 2022-07-18 at 12 33 52

@devkennyy
Copy link
Owner Author

Can you add a few test themes and show what it would look like? Just the div, no styles.

@knight-95
Copy link
Contributor

knight-95 commented Jul 18, 2022

Can you add a few test themes and show what it would look like? Just the div, no styles.

When we will have more themes, then instead of making the div at center we can shift it rightwards/leftwards, so it would look much nicer and cleaner
Screenshot 2022-07-19 at 01 17 45

@devkennyy
Copy link
Owner Author

devkennyy commented Jul 19, 2022

I'm not sure this is the solution we should go for. Can you try something else?

@Trevy05
Copy link

Trevy05 commented Jul 19, 2022

A fixed dropdown menu with a scrollbar seems like the most logical solution.

@devkennyy devkennyy reopened this Jul 25, 2022
@devkennyy devkennyy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Beginner friendly issues. You do not need permission to work on these.
Projects
None yet
Development

No branches or pull requests

3 participants