Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shaderInstanceInit doesn't initialize numFloat24Uniforms if no constant table is present #535

Closed
neobrain opened this issue Dec 16, 2023 · 0 comments
Closed

shaderInstanceInit doesn't initialize numFloat24Uniforms if no constant table is present #535

neobrain opened this issue Dec 16, 2023 · 0 comments

Comments

@neobrain
Copy link
Contributor

Trying to use shaderInstanceInit on a DVLE with no constant table will leave si->numFloat24Uniforms uninitialized (instead, only si->float24Uniforms gets set to null). This causes problems in citro3d's uniform managing code, which assumes si->numFloat24Uniforms to be zero if no constants are provided.

It seems reasonable to me that citro3d behaves like this. libctru should just set numFloat24Uniforms to 0 instead by default.
@fincs fincs closed this as completed in d0936b8 Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neobrain