Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build #21

Closed
jlucfarias opened this issue Jun 22, 2019 · 3 comments
Closed

Can't build #21

jlucfarias opened this issue Jun 22, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jlucfarias
Copy link

Hi, i created a theme with npx create-react-wptheme testetheme but i can't even build. I'm using the latest version

The response when i run yarn build is TypeError: Cannot read property 'homepage' of null at module.exports (C:\Users\lucas\Documents\testetheme\node_modules\@devloco\react-scripts-wptheme\config\webpack.config.wptheme.js:77:25)

testetheme.zip

@devloco devloco self-assigned this Jun 22, 2019
@devloco
Copy link
Owner

devloco commented Jun 22, 2019

Hi @John-Luke , I'm creating a new theme as I type this to check this out.

But the first thing that comes to mind is: did you complete the PHP portion of the setup?

@devloco
Copy link
Owner

devloco commented Jun 22, 2019

Hi @John-Luke,

Yes I get this exact same error if I run yarn build without completing the PHP portion of the setup. Thanks for pointing this out.

I'll improve the script to at least print a nicer error.... or maybe I'll run yarn start for you when all configs are missing.

@devloco devloco added the bug Something isn't working label Jun 22, 2019
@devloco
Copy link
Owner

devloco commented Jun 23, 2019

I actually already had code to do this check, but it wasn't executing soon enough in the process.

Fixed now in @devloco/react-scripts-wptheme version 3.0.1-wptheme-3.0.5.

@devloco devloco closed this as completed Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants