Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user.prod.json homepage property not used on wpbuild #9

Closed
mikelinden1 opened this issue Jan 4, 2019 · 9 comments
Closed

user.prod.json homepage property not used on wpbuild #9

mikelinden1 opened this issue Jan 4, 2019 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@mikelinden1
Copy link

When I run node run wpbuild the homepage property set in user.prod.json isn't used - it uses the homepage property in my package.json. I also tried removing the homepage prop in package.json and moving it to user.dev.json but then it used the root as the homepage.

@mikelinden1 mikelinden1 changed the title user.prod.json homepage not used on wpbuild user.prod.json homepage property not used on wpbuild Jan 4, 2019
@mikelinden1
Copy link
Author

Also, thank you for creating this amazing tool - it solved some headaches!

@devloco
Copy link
Owner

devloco commented Jan 4, 2019

That's a bummer. I'll take a look this weekend and get 'er fixed.

@devloco
Copy link
Owner

devloco commented Jan 4, 2019

And thanks for the kind words!

@devloco devloco self-assigned this Jan 4, 2019
@devloco devloco added the bug Something isn't working label Jan 4, 2019
@devloco
Copy link
Owner

devloco commented Jan 5, 2019

I haven't had a chance to look at this yet, but I was thinking, maybe you're running an older version? There was a time that the build command was a known problem:
#5
And then recently someone else seemed to indicate that changes to user.prod.json worked for them:
#8

So I'm wondering if maybe you started the theme you're working from the known-bad-build version, and maybe updating to the latest will get it sorted out. Updating instructions here:
Updating

Anyway, I'm still planning to look at this tomorrow or Sunday, but if you're running the old version, then you can get yourself working tonight.

@mikelinden1
Copy link
Author

mikelinden1 commented Jan 7, 2019

I just ran the update and it took me to "@devloco/react-scripts-wptheme": "^2.1.2-wptheme-2.1.5", (I was on "@devloco/react-scripts-wptheme": "2.1.1-wptheme-2.1.4", before) but the problem persists. Thanks for your help so far!

@devloco
Copy link
Owner

devloco commented Jan 7, 2019

FYI: I am able to reproduce this. I'll get a fix out tonight.

@devloco
Copy link
Owner

devloco commented Jan 7, 2019

I was able to get npm run build to work with @devloco/react-scripts-wptheme version 2.1.2-wptheme-2.1.9.

Hopefully that'll work for you as well. I'll leave this ticket open for now.

Apologies for the delay!

@mikelinden1
Copy link
Author

Oh great. I'll take a look tomorrow and let you know!

@mikelinden1
Copy link
Author

That did the trick - thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants